[jira] [Commented] (GIRAPH-121) BasicVertexResolver should be implementation and VertexResolver should be interface

["Paolo Castagna (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285662#comment-13285662 ] 

Paolo Castagna commented on GIRAPH-121:
---------------------------------------

This is 'trivial' however there is a small problem: should the setGraphState() method be added to the VertexResolver interface?

{code:java}
  @SuppressWarnings("rawtypes")
  public static <I extends WritableComparable, V extends Writable,
  E extends Writable, M extends Writable> VertexResolver<I, V, E, M>
  createVertexResolver(Configuration conf,
    GraphState<I, V, E, M> graphState) {
    Class<? extends VertexResolver<I, V, E, M>> vertexResolverClass =
      getVertexResolverClass(conf);
    VertexResolver<I, V, E, M> resolver =
      ReflectionUtils.newInstance(vertexResolverClass, conf);
    resolver.setGraphState(graphState);
    return resolver;
  }
{code}
                
> BasicVertexResolver should be implementation and VertexResolver should be interface
> -----------------------------------------------------------------------------------
>
>                 Key: GIRAPH-121
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-121
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.1.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Trivial
>              Labels: newbie
>
> After the change of naming in Vertex, VertexResolver and BasicVertexResolver naming should be synched.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira