You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/25 11:45:44 UTC
[GitHub] [pulsar] racorn opened a new pull request #8137: Add ChannelFutures utility class to pulsar-common.
racorn opened a new pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137
### Motivation
Pulsar code uses `CompletableFuture` to implement asynchronous execution paths. When interacting with Netty, a common pattern is to create a `CompletableFuture` and some glue code to listen for Netty `ChannelFuture` completions and then complete the `CompletableFuture`. The code would be more ease to read if we add static utility class for adapting a `io.netty.channel.ChannelFuture` to a `java.util.concurrent.CompletableFuture`.
### Modifications
- Added `org.apache.pulsar.common.util.netty.ChannelFutures`
### Verifying this change
- Added test class `ChannelFuturesTest`
### Documentation
- JavaDocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137#issuecomment-699064116
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137#issuecomment-698991610
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137#issuecomment-698925065
@rdhabalia can you please take a look? I will use this class to improve code committed in #8117 :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137#issuecomment-699888270
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137#issuecomment-717756064
Move this change to 2.6.2, because the #8177 depends on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8137: Add ChannelFutures utility class to pulsar-common.
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8137:
URL: https://github.com/apache/pulsar/pull/8137#issuecomment-698940978
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org