You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by David Jencks <da...@yahoo.com> on 2006/06/06 23:27:32 UTC
[RTC] m2-plugins deployment plugin
Prasad has been working for a long time on an m2 deployment plugin.
I've cleaned up his latest patch a little bit and think its ready to
commit.
Please review http://issues.apache.org/jira/secure/attachment/
12335116/geronimo-deployment-plugin-RTC-VOTE.patch
This is a straightforward port of the m1 deployment plugin to m2. I
don't see any new functionality. He's removed the stuff that doesn't
belong in a deployment plugin (such as unpackserver and velocity
filtering) and left the commands that start/stop the server and
perfom the actual deployment commands.
At the moment it's hard to test this since there is no m2-built
geronimo server nor any itests to use it in. I would like to commit
this now so it doesn't get lost and fix any problems later.
Here's my +1.
thanks
david jencks
Re: [RTC] m2-plugins deployment plugin
Posted by Guillaume Nodet <gu...@worldonline.fr>.
FYI, if you have ASF license header in the pom, it will be removed by
the release plugin
during the release process (before tagging if I recall) ...
Cheers,
Guillaume Nodet
Jacek Laskowski wrote:
> On 6/6/06, David Jencks <da...@yahoo.com> wrote:
>
>> Prasad has been working for a long time on an m2 deployment plugin.
>> I've cleaned up his latest patch a little bit and think its ready to
>> commit.
>>
>> Please review http://issues.apache.org/jira/secure/attachment/
>> 12335116/geronimo-deployment-plugin-RTC-VOTE.patch
>
>
> I have taken a look at the patch and the comments are as follows
> (they're rather style-centric nor technical, but still valid I hope).
> No testing was performed.
>
> 1/ I was scared to read: "May not have been tested." in one of the
> classes
>
> 2/ Copyright 2004-2006 - shouldn't it be Copyright 2006 only?
>
> 3/ The javadoc of classes should be consistent. It means that it
> should read:
>
> /**
> * @goal undeploy (if appropriate)
> *
> * @version $Rev$ $Date$
> */
>
> whereas some contain
>
> @version $Revision$ $Date$
>
> or no version at all.
>
> 4/ Geronimo :: Maven Deployment Plugin using m2 -> Geronimo :: Maven 2
> Deployment Plugin or alternatively Geronimo :: Maven Deployment Plugin
> for Maven 2, but I'd prefer the former.
>
> 5/ geronimo-deployment-plugin/pom.xml has no ASF license header.
>
> So, unless it's corrected I'm -1. If you're swampped with your other
> work, I can take care of it and propose the patch corrected again.
>
>> Here's my +1.
>
>
> It doesn't count, though ;-)
>
>> david jencks
>
>
> Jacek
>
Re: [RTC] m2-plugins deployment plugin
Posted by Dain Sundstrom <da...@iq80.com>.
On Jun 7, 2006, at 10:18 AM, Jacek Laskowski wrote:
> On 6/7/06, Dain Sundstrom <da...@iq80.com> wrote:
>> On Jun 7, 2006, at 5:43 AM, Jacek Laskowski wrote:
>>
>> > On 6/7/06, David Jencks <da...@yahoo.com> wrote:
>> >> > It doesn't count, though ;-)
>> >>
>> >> Why not? Because I edited prasad's patch for formatting and
>> removed
>> >> unused cruft? Ken's directive requires 3 +1 votes from committers
>> >> other than the proposer (who apparently does not need to be a
>> >> committer): although the document he appears to have adapted
>> states
>> >> only PMC member votes count, that is not in his directive.
>> Since he
>> >> hasn't responded to requests for clarification I think we have to
>> >> take him at his word.
>> >
>> > The proposer (!= the author) == DJ nor Prasad => DJ may not vote
>> for
>> > it. Is that correct?
>>
>> FWIU, everyone can vote, but only the votes of committers count. To
>> apply a patch, you need 4 +1 votes, and your own +1 counts as the
>> first of the four.
>
> That's exactly how I understand it! Note the difference in the numbers
> - I hope it's not a mistake - there's 4 +1 votes in your email whereas
> Dave mentioned 3 +1 votes. The difference is where I stand - apart
> from Dave's own +1 he needs 3 more, doesn't he?
I seem to have cut of the important part of david's email. Anyway, I
agree he needs 3 more +1 in addition to his own.
-dain
Re: [RTC] m2-plugins deployment plugin
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/7/06, Dain Sundstrom <da...@iq80.com> wrote:
> On Jun 7, 2006, at 5:43 AM, Jacek Laskowski wrote:
>
> > On 6/7/06, David Jencks <da...@yahoo.com> wrote:
> >> > It doesn't count, though ;-)
> >>
> >> Why not? Because I edited prasad's patch for formatting and removed
> >> unused cruft? Ken's directive requires 3 +1 votes from committers
> >> other than the proposer (who apparently does not need to be a
> >> committer): although the document he appears to have adapted states
> >> only PMC member votes count, that is not in his directive. Since he
> >> hasn't responded to requests for clarification I think we have to
> >> take him at his word.
> >
> > The proposer (!= the author) == DJ nor Prasad => DJ may not vote for
> > it. Is that correct?
>
> FWIU, everyone can vote, but only the votes of committers count. To
> apply a patch, you need 4 +1 votes, and your own +1 counts as the
> first of the four.
That's exactly how I understand it! Note the difference in the numbers
- I hope it's not a mistake - there's 4 +1 votes in your email whereas
Dave mentioned 3 +1 votes. The difference is where I stand - apart
from Dave's own +1 he needs 3 more, doesn't he?
> -dain
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin
Posted by Dain Sundstrom <da...@iq80.com>.
On Jun 7, 2006, at 5:43 AM, Jacek Laskowski wrote:
> On 6/7/06, David Jencks <da...@yahoo.com> wrote:
>> > It doesn't count, though ;-)
>>
>> Why not? Because I edited prasad's patch for formatting and removed
>> unused cruft? Ken's directive requires 3 +1 votes from committers
>> other than the proposer (who apparently does not need to be a
>> committer): although the document he appears to have adapted states
>> only PMC member votes count, that is not in his directive. Since he
>> hasn't responded to requests for clarification I think we have to
>> take him at his word.
>
> The proposer (!= the author) == DJ nor Prasad => DJ may not vote for
> it. Is that correct?
FWIU, everyone can vote, but only the votes of committers count. To
apply a patch, you need 4 +1 votes, and your own +1 counts as the
first of the four.
-dain
Re: [RTC] m2-plugins deployment plugin
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/7/06, David Jencks <da...@yahoo.com> wrote:
> I've uploaded
>
> http://issues.apache.org/jira/secure/attachment/12335128/geronimo-
> deployment-plugin-RTC-VOTE.2.patch
>
> incorporating most of your comments, see below.
Will take a look at it real soon. More below.
> david jencks
...
> You want me to lie :-) ? I don't think anyone has ever used the in-vm
> startServer command in the m1 plugin, so I doubt prasad has tested
> this one either. I still think its worth including as a starting
> point in case some one wants to try it out.
Ah, it's a comment to let others know it's untested. Wouldn't it be
better adding TODO or FIXME so there's no doubt about it?
> These are basically copies + modifications of the m1 deployment
> plugin, copyright 2004. I don't know if any changes happened in
> 2005, but 2004 and 2006 are definitely needed.
Well, I'm not a lawer so can't elaborate more on it. I can live with it ;-)
> They should all have the @version, but only mojos should have the
> @goal in order to not confuse maven. I've fixed the @version tags as
> well as I can find them.
Correct. That was my understanding.
> > 5/ geronimo-deployment-plugin/pom.xml has no ASF license header.
> fixed. I think its better to include the asf license in the source
> even if maven removes it during processing.
Correct. No matter how tools will work with the sources they need to
be copyrighted appropriately.
> > It doesn't count, though ;-)
>
> Why not? Because I edited prasad's patch for formatting and removed
> unused cruft? Ken's directive requires 3 +1 votes from committers
> other than the proposer (who apparently does not need to be a
> committer): although the document he appears to have adapted states
> only PMC member votes count, that is not in his directive. Since he
> hasn't responded to requests for clarification I think we have to
> take him at his word.
The proposer (!= the author) == DJ nor Prasad => DJ may not vote for
it. Is that correct?
> david jencks
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Prasad Kashyap <go...@gmail.com>.
Ah. So I wasn't the only one missing the deps. Jacek, you may find the
patch here.
http://www.mail-archive.com/dev@geronimo.apache.org/msg25267.html
Can you please patch it using
http://issues.apache.org/jira/browse/GERONIMO-2149 ?
Cheers
Prasad
On 6/25/06, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> On 6/25/06, David Jencks <da...@yahoo.com> wrote:
>
> > Something is odd, you should be able to build all the modules before
> > any plugins. Have you run mvn -N install in geronimo's root directory?
>
> Duh! Should've been executed mvn -N install rather mvn -U install.
> Anyway, it doesn't work either. Now ended up with the following
> exception:
>
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Compilation failure
>
> c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[20,17]
> package javax.ejb does not exist
>
> c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[21,17]
> package javax.ejb does not exist
>
> c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[22,17]
> package javax.ejb does not exist
>
> c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[23,17]
> package javax.ejb does not exist
>
> c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[49,7]
> cannot access javax.ejb.EJBObject
>
> > david jencks
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
>
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/25/06, David Jencks <da...@yahoo.com> wrote:
> Something is odd, you should be able to build all the modules before
> any plugins. Have you run mvn -N install in geronimo's root directory?
Duh! Should've been executed mvn -N install rather mvn -U install.
Anyway, it doesn't work either. Now ended up with the following
exception:
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[20,17]
package javax.ejb does not exist
c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[21,17]
package javax.ejb does not exist
c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[22,17]
package javax.ejb does not exist
c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[23,17]
package javax.ejb does not exist
c:\oss\geronimo\modules\j2ee\src\java\org\apache\geronimo\j2ee\mejb\MEJB.java:[49,7]
cannot access javax.ejb.EJBObject
> david jencks
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/26/06, Aaron Mulder <am...@alumni.princeton.edu> wrote:
> I think if you try again the stax and jsr173 problems will not happen.
> It's only after the first clean build in an XMLBeans directory that
> they happen. Unfortunately, that may mean they happen on like 10
> different modules.
>
> Apparently this is due to errors in the XMLBeans plugin or POM and
> David J had an idea of how to patch things locally to make this go
> away.
Thanks Aaron, but it didn't help, either. I tried building j2ee-schema
a couple of times and all finished with the exception:
Missing:
----------
1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
You're right about XMLBeans issue with its pom which I remember I read
on maven-dev mailing list. I think it might be that others use
not-that-recent xmlbeans from maven2 repo and unless they run with -U
option set they won't experience it.
> Aaron
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
I think if you try again the stax and jsr173 problems will not happen.
It's only after the first clean build in an XMLBeans directory that
they happen. Unfortunately, that may mean they happen on like 10
different modules.
Apparently this is due to errors in the XMLBeans plugin or POM and
David J had an idea of how to patch things locally to make this go
away.
Thanks,
Aaron
On 6/26/06, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> On 6/26/06, Prasad Kashyap <go...@gmail.com> wrote:
> > Yes modules should first be built
> >
> > The execeptions are caused by missing deps in the modules. Nothing to
> > do with the deployment plugin.
>
> Almost there. I was misled by the exception wrt xmlbeans and didn't
> apply the patch for the missing deps. Anyway, once done the build
> failed with the following error:
>
> Downloading: http://dist.codehaus.org/xmlbeans/poms/xmlbeans-jsr173-api-2.0-dev.pom
> [WARNING] Unable to get resource from repository codehaus-dist
> (http://dist.codehaus.org)
> Downloading: http://people.apache.org/maven-snapshot-repository/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.pom
> [WARNING] Unable to get resource from repository Apache CVS
> (http://people.apache.org/maven-snapshot-repository)
> Downloading: http://www.ibiblio.org/maven/xmlbeans/poms/xmlbeans-jsr173-api-2.0-dev.pom
> [WARNING] Unable to get resource from repository maven1-ibiblio
> (http://www.ibiblio.org/maven)
> Downloading: http://www.ibiblio.org/maven2/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.pom
> [WARNING] Unable to get resource from repository central
> (http://repo1.maven.org/maven2)
> Downloading: http://cvs.apache.org/repository/xmlbeans/poms/xmlbeans-jsr173-api-2.0-dev.pom
> [WARNING] Unable to get resource from repository apache-cvs
> (http://cvs.apache.org/repository)
> Downloading: http://dist.codehaus.org/xmlbeans/jars/xmlbeans-jsr173-api-2.0-dev.jar
> [WARNING] Unable to get resource from repository codehaus-dist
> (http://dist.codehaus.org)
> Downloading: http://people.apache.org/maven-snapshot-repository/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.jar
> [WARNING] Unable to get resource from repository Apache CVS
> (http://people.apache.org/maven-snapshot-repository)
> Downloading: http://www.ibiblio.org/maven/xmlbeans/jars/xmlbeans-jsr173-api-2.0-dev.jar
> [WARNING] Unable to get resource from repository maven1-ibiblio
> (http://www.ibiblio.org/maven)
> Downloading: http://cvs.apache.org/repository/xmlbeans/jars/xmlbeans-jsr173-api-2.0-dev.jar
> [WARNING] Unable to get resource from repository apache-cvs
> (http://cvs.apache.org/repository)
> Downloading: http://www.ibiblio.org/maven2/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.jar
> [WARNING] Unable to get resource from repository central
> (http://repo1.maven.org/maven2)
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Failed to resolve artifact.
>
> Missing:
> ----------
> 1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
>
> Try downloading the file manually from the project website.
>
> Then, install it using the command:
> mvn install:install-file -DgroupId=xmlbeans
> -DartifactId=xmlbeans-jsr173-api \
> -Dversion=2.0-dev -Dpackaging=jar -Dfile=/path/to/file
>
> Path to dependency:
> 1) org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
> 2) stax:stax:jar:1.1.1-dev
> 3) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
>
> ----------
> 1 required artifact is missing.
>
> for artifact:
> org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
>
> > Prasad
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
>
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/26/06, Prasad Kashyap <go...@gmail.com> wrote:
> Yes modules should first be built
>
> The execeptions are caused by missing deps in the modules. Nothing to
> do with the deployment plugin.
Almost there. I was misled by the exception wrt xmlbeans and didn't
apply the patch for the missing deps. Anyway, once done the build
failed with the following error:
Downloading: http://dist.codehaus.org/xmlbeans/poms/xmlbeans-jsr173-api-2.0-dev.pom
[WARNING] Unable to get resource from repository codehaus-dist
(http://dist.codehaus.org)
Downloading: http://people.apache.org/maven-snapshot-repository/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.pom
[WARNING] Unable to get resource from repository Apache CVS
(http://people.apache.org/maven-snapshot-repository)
Downloading: http://www.ibiblio.org/maven/xmlbeans/poms/xmlbeans-jsr173-api-2.0-dev.pom
[WARNING] Unable to get resource from repository maven1-ibiblio
(http://www.ibiblio.org/maven)
Downloading: http://www.ibiblio.org/maven2/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.pom
[WARNING] Unable to get resource from repository central
(http://repo1.maven.org/maven2)
Downloading: http://cvs.apache.org/repository/xmlbeans/poms/xmlbeans-jsr173-api-2.0-dev.pom
[WARNING] Unable to get resource from repository apache-cvs
(http://cvs.apache.org/repository)
Downloading: http://dist.codehaus.org/xmlbeans/jars/xmlbeans-jsr173-api-2.0-dev.jar
[WARNING] Unable to get resource from repository codehaus-dist
(http://dist.codehaus.org)
Downloading: http://people.apache.org/maven-snapshot-repository/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.jar
[WARNING] Unable to get resource from repository Apache CVS
(http://people.apache.org/maven-snapshot-repository)
Downloading: http://www.ibiblio.org/maven/xmlbeans/jars/xmlbeans-jsr173-api-2.0-dev.jar
[WARNING] Unable to get resource from repository maven1-ibiblio
(http://www.ibiblio.org/maven)
Downloading: http://cvs.apache.org/repository/xmlbeans/jars/xmlbeans-jsr173-api-2.0-dev.jar
[WARNING] Unable to get resource from repository apache-cvs
(http://cvs.apache.org/repository)
Downloading: http://www.ibiblio.org/maven2/xmlbeans/xmlbeans-jsr173-api/2.0-dev/xmlbeans-jsr173-api-2.0-dev.jar
[WARNING] Unable to get resource from repository central
(http://repo1.maven.org/maven2)
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.
Missing:
----------
1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=xmlbeans
-DartifactId=xmlbeans-jsr173-api \
-Dversion=2.0-dev -Dpackaging=jar -Dfile=/path/to/file
Path to dependency:
1) org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
2) stax:stax:jar:1.1.1-dev
3) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
----------
1 required artifact is missing.
for artifact:
org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
> Prasad
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Prasad Kashyap <go...@gmail.com>.
Yes modules should first be built
The execeptions are caused by missing deps in the modules. Nothing to
do with the deployment plugin.
Cheers
Prasad
On 6/25/06, David Jencks <da...@yahoo.com> wrote:
>
> On Jun 25, 2006, at 4:06 AM, Jacek Laskowski wrote:
>
> > On 6/13/06, David Jencks <da...@yahoo.com> wrote:
> >> Last (and only, depending on how you count) +1 was 4 days ago, any
> >> chance 2 more people are willing to review this?
> >
> > I can't seem to test it out on my laptop with no Geronimo m2 builds
> > done before. See
> > http://issues.apache.org/jira/browse/GERONIMO-1738#action_12417669 for
> > more information.
>
> Something is odd, you should be able to build all the modules before
> any plugins. Have you run mvn -N install in geronimo's root directory?
>
> I'd expect this to work:
>
> cd /cygdrive/c/oss/geronimo
> mvn -N install
> cd modules
> mvn clean install
> cd ../m2-plugins
> mvn clean install
>
> I haven't tried this myself yet with a fresh repo.... will try to
> find some time for this.
>
>
> >
> > Therefore, I can't vote for it. Does it mean I should vote against it
> > in such a case?
> >
>
> I think we should investigate the problems further before voting
> further.
>
> thanks
> david jencks
>
>
> >> david jencks
> >
> > Jacek
> >
> > --
> > Jacek Laskowski
> > http://www.laskowski.net.pl
>
>
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by anita kulshreshtha <a_...@yahoo.com>.
AFAIK, maven makes sure that it has all the plugins even before
sorting the projects. It can not distinguish the fact that a subset of
the projects do not need the plugin. Ideally maven should distinguish
between a maven plugin and other plugins. If m2 snapshots are
published somewhere, it will get an older copy of the plugins and
happily continue the build.
Thanks
Anita
--- David Jencks <da...@yahoo.com> wrote:
>
> On Jun 25, 2006, at 4:06 AM, Jacek Laskowski wrote:
>
> > On 6/13/06, David Jencks <da...@yahoo.com> wrote:
> >> Last (and only, depending on how you count) +1 was 4 days ago, any
> >> chance 2 more people are willing to review this?
> >
> > I can't seem to test it out on my laptop with no Geronimo m2 builds
> > done before. See
> > http://issues.apache.org/jira/browse/GERONIMO-1738#action_12417669
> for
> > more information.
>
> Something is odd, you should be able to build all the modules before
>
> any plugins. Have you run mvn -N install in geronimo's root
> directory?
>
> I'd expect this to work:
>
> cd /cygdrive/c/oss/geronimo
> mvn -N install
> cd modules
> mvn clean install
> cd ../m2-plugins
> mvn clean install
>
> I haven't tried this myself yet with a fresh repo.... will try to
> find some time for this.
>
>
> >
> > Therefore, I can't vote for it. Does it mean I should vote against
> it
> > in such a case?
> >
>
> I think we should investigate the problems further before voting
> further.
>
> thanks
> david jencks
>
>
> >> david jencks
> >
> > Jacek
> >
> > --
> > Jacek Laskowski
> > http://www.laskowski.net.pl
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by David Jencks <da...@yahoo.com>.
On Jun 25, 2006, at 4:06 AM, Jacek Laskowski wrote:
> On 6/13/06, David Jencks <da...@yahoo.com> wrote:
>> Last (and only, depending on how you count) +1 was 4 days ago, any
>> chance 2 more people are willing to review this?
>
> I can't seem to test it out on my laptop with no Geronimo m2 builds
> done before. See
> http://issues.apache.org/jira/browse/GERONIMO-1738#action_12417669 for
> more information.
Something is odd, you should be able to build all the modules before
any plugins. Have you run mvn -N install in geronimo's root directory?
I'd expect this to work:
cd /cygdrive/c/oss/geronimo
mvn -N install
cd modules
mvn clean install
cd ../m2-plugins
mvn clean install
I haven't tried this myself yet with a fresh repo.... will try to
find some time for this.
>
> Therefore, I can't vote for it. Does it mean I should vote against it
> in such a case?
>
I think we should investigate the problems further before voting
further.
thanks
david jencks
>> david jencks
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/13/06, David Jencks <da...@yahoo.com> wrote:
> Last (and only, depending on how you count) +1 was 4 days ago, any
> chance 2 more people are willing to review this?
I can't seem to test it out on my laptop with no Geronimo m2 builds
done before. See
http://issues.apache.org/jira/browse/GERONIMO-1738#action_12417669 for
more information.
Therefore, I can't vote for it. Does it mean I should vote against it
in such a case?
> david jencks
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin: PLEASE VOTE
Posted by David Jencks <da...@yahoo.com>.
Last (and only, depending on how you count) +1 was 4 days ago, any
chance 2 more people are willing to review this?
thanks
david jencks
On Jun 9, 2006, at 7:51 AM, Guillaume Nodet wrote:
> +1
>
> Cheers,
> Guillaume Nodet
>
> David Jencks wrote:
>
>> I've uploaded
>>
>> http://issues.apache.org/jira/secure/attachment/12335128/geronimo-
>> deployment-plugin-RTC-VOTE.2.patch
>>
>> incorporating most of your comments, see below.
>>
>> Thanks for the review!
>>
>> david jencks
>>
>> On Jun 6, 2006, at 11:57 PM, Jacek Laskowski wrote:
>>
>>> On 6/6/06, David Jencks <da...@yahoo.com> wrote:
>>>
>>>> Prasad has been working for a long time on an m2 deployment plugin.
>>>> I've cleaned up his latest patch a little bit and think its
>>>> ready to
>>>> commit.
>>>>
>>>> Please review http://issues.apache.org/jira/secure/attachment/
>>>> 12335116/geronimo-deployment-plugin-RTC-VOTE.patch
>>>
>>>
>>> I have taken a look at the patch and the comments are as follows
>>> (they're rather style-centric nor technical, but still valid I
>>> hope).
>>> No testing was performed.
>>>
>>> 1/ I was scared to read: "May not have been tested." in one of
>>> the classes
>>
>>
>> You want me to lie :-) ? I don't think anyone has ever used the in-
>> vm startServer command in the m1 plugin, so I doubt prasad has
>> tested this one either. I still think its worth including as a
>> starting point in case some one wants to try it out.
>>
>>>
>>> 2/ Copyright 2004-2006 - shouldn't it be Copyright 2006 only?
>>
>>
>> These are basically copies + modifications of the m1 deployment
>> plugin, copyright 2004. I don't know if any changes happened in
>> 2005, but 2004 and 2006 are definitely needed.
>>
>>>
>>> 3/ The javadoc of classes should be consistent. It means that it
>>> should read:
>>>
>>> /**
>>> * @goal undeploy (if appropriate)
>>> *
>>> * @version $Rev$ $Date$
>>> */
>>>
>>> whereas some contain
>>>
>>> @version $Revision$ $Date$
>>>
>>> or no version at all.
>>
>>
>> They should all have the @version, but only mojos should have the
>> @goal in order to not confuse maven. I've fixed the @version tags
>> as well as I can find them.
>>
>>>
>>> 4/ Geronimo :: Maven Deployment Plugin using m2 -> Geronimo ::
>>> Maven 2
>>> Deployment Plugin or alternatively Geronimo :: Maven Deployment
>>> Plugin
>>> for Maven 2, but I'd prefer the former.
>>
>>
>> fixed
>>
>>>
>>> 5/ geronimo-deployment-plugin/pom.xml has no ASF license header.
>>
>> fixed. I think its better to include the asf license in the
>> source even if maven removes it during processing.
>>
>>
>>>
>>> So, unless it's corrected I'm -1. If you're swampped with your other
>>> work, I can take care of it and propose the patch corrected again.
>>>
>>>> Here's my +1.
>>>
>>>
>>> It doesn't count, though ;-)
>>
>>
>> Why not? Because I edited prasad's patch for formatting and
>> removed unused cruft? Ken's directive requires 3 +1 votes from
>> committers other than the proposer (who apparently does not need
>> to be a committer): although the document he appears to have
>> adapted states only PMC member votes count, that is not in his
>> directive. Since he hasn't responded to requests for
>> clarification I think we have to take him at his word.
>>
>> thanks
>> david jencks
>>
>>
>>
>>>
>>>> david jencks
>>>
>>>
>>> Jacek
>>>
>>> --
>>> Jacek Laskowski
>>> http://www.laskowski.net.pl
>>
>>
>>
>>
Re: [RTC] m2-plugins deployment plugin
Posted by Guillaume Nodet <gu...@worldonline.fr>.
+1
Cheers,
Guillaume Nodet
David Jencks wrote:
> I've uploaded
>
> http://issues.apache.org/jira/secure/attachment/12335128/geronimo-
> deployment-plugin-RTC-VOTE.2.patch
>
> incorporating most of your comments, see below.
>
> Thanks for the review!
>
> david jencks
>
> On Jun 6, 2006, at 11:57 PM, Jacek Laskowski wrote:
>
>> On 6/6/06, David Jencks <da...@yahoo.com> wrote:
>>
>>> Prasad has been working for a long time on an m2 deployment plugin.
>>> I've cleaned up his latest patch a little bit and think its ready to
>>> commit.
>>>
>>> Please review http://issues.apache.org/jira/secure/attachment/
>>> 12335116/geronimo-deployment-plugin-RTC-VOTE.patch
>>
>>
>> I have taken a look at the patch and the comments are as follows
>> (they're rather style-centric nor technical, but still valid I hope).
>> No testing was performed.
>>
>> 1/ I was scared to read: "May not have been tested." in one of the
>> classes
>
>
> You want me to lie :-) ? I don't think anyone has ever used the in-vm
> startServer command in the m1 plugin, so I doubt prasad has tested
> this one either. I still think its worth including as a starting
> point in case some one wants to try it out.
>
>>
>> 2/ Copyright 2004-2006 - shouldn't it be Copyright 2006 only?
>
>
> These are basically copies + modifications of the m1 deployment
> plugin, copyright 2004. I don't know if any changes happened in
> 2005, but 2004 and 2006 are definitely needed.
>
>>
>> 3/ The javadoc of classes should be consistent. It means that it
>> should read:
>>
>> /**
>> * @goal undeploy (if appropriate)
>> *
>> * @version $Rev$ $Date$
>> */
>>
>> whereas some contain
>>
>> @version $Revision$ $Date$
>>
>> or no version at all.
>
>
> They should all have the @version, but only mojos should have the
> @goal in order to not confuse maven. I've fixed the @version tags as
> well as I can find them.
>
>>
>> 4/ Geronimo :: Maven Deployment Plugin using m2 -> Geronimo :: Maven 2
>> Deployment Plugin or alternatively Geronimo :: Maven Deployment Plugin
>> for Maven 2, but I'd prefer the former.
>
>
> fixed
>
>>
>> 5/ geronimo-deployment-plugin/pom.xml has no ASF license header.
>
> fixed. I think its better to include the asf license in the source
> even if maven removes it during processing.
>
>
>>
>> So, unless it's corrected I'm -1. If you're swampped with your other
>> work, I can take care of it and propose the patch corrected again.
>>
>>> Here's my +1.
>>
>>
>> It doesn't count, though ;-)
>
>
> Why not? Because I edited prasad's patch for formatting and removed
> unused cruft? Ken's directive requires 3 +1 votes from committers
> other than the proposer (who apparently does not need to be a
> committer): although the document he appears to have adapted states
> only PMC member votes count, that is not in his directive. Since he
> hasn't responded to requests for clarification I think we have to
> take him at his word.
>
> thanks
> david jencks
>
>
>
>>
>>> david jencks
>>
>>
>> Jacek
>>
>> --
>> Jacek Laskowski
>> http://www.laskowski.net.pl
>
>
>
>
Re: [RTC] m2-plugins deployment plugin
Posted by David Jencks <da...@yahoo.com>.
I've uploaded
http://issues.apache.org/jira/secure/attachment/12335128/geronimo-
deployment-plugin-RTC-VOTE.2.patch
incorporating most of your comments, see below.
Thanks for the review!
david jencks
On Jun 6, 2006, at 11:57 PM, Jacek Laskowski wrote:
> On 6/6/06, David Jencks <da...@yahoo.com> wrote:
>> Prasad has been working for a long time on an m2 deployment plugin.
>> I've cleaned up his latest patch a little bit and think its ready to
>> commit.
>>
>> Please review http://issues.apache.org/jira/secure/attachment/
>> 12335116/geronimo-deployment-plugin-RTC-VOTE.patch
>
> I have taken a look at the patch and the comments are as follows
> (they're rather style-centric nor technical, but still valid I hope).
> No testing was performed.
>
> 1/ I was scared to read: "May not have been tested." in one of the
> classes
You want me to lie :-) ? I don't think anyone has ever used the in-vm
startServer command in the m1 plugin, so I doubt prasad has tested
this one either. I still think its worth including as a starting
point in case some one wants to try it out.
>
> 2/ Copyright 2004-2006 - shouldn't it be Copyright 2006 only?
These are basically copies + modifications of the m1 deployment
plugin, copyright 2004. I don't know if any changes happened in
2005, but 2004 and 2006 are definitely needed.
>
> 3/ The javadoc of classes should be consistent. It means that it
> should read:
>
> /**
> * @goal undeploy (if appropriate)
> *
> * @version $Rev$ $Date$
> */
>
> whereas some contain
>
> @version $Revision$ $Date$
>
> or no version at all.
They should all have the @version, but only mojos should have the
@goal in order to not confuse maven. I've fixed the @version tags as
well as I can find them.
>
> 4/ Geronimo :: Maven Deployment Plugin using m2 -> Geronimo :: Maven 2
> Deployment Plugin or alternatively Geronimo :: Maven Deployment Plugin
> for Maven 2, but I'd prefer the former.
fixed
>
> 5/ geronimo-deployment-plugin/pom.xml has no ASF license header.
fixed. I think its better to include the asf license in the source
even if maven removes it during processing.
>
> So, unless it's corrected I'm -1. If you're swampped with your other
> work, I can take care of it and propose the patch corrected again.
>
>> Here's my +1.
>
> It doesn't count, though ;-)
Why not? Because I edited prasad's patch for formatting and removed
unused cruft? Ken's directive requires 3 +1 votes from committers
other than the proposer (who apparently does not need to be a
committer): although the document he appears to have adapted states
only PMC member votes count, that is not in his directive. Since he
hasn't responded to requests for clarification I think we have to
take him at his word.
thanks
david jencks
>
>> david jencks
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
Re: [RTC] m2-plugins deployment plugin
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 6/6/06, David Jencks <da...@yahoo.com> wrote:
> Prasad has been working for a long time on an m2 deployment plugin.
> I've cleaned up his latest patch a little bit and think its ready to
> commit.
>
> Please review http://issues.apache.org/jira/secure/attachment/
> 12335116/geronimo-deployment-plugin-RTC-VOTE.patch
I have taken a look at the patch and the comments are as follows
(they're rather style-centric nor technical, but still valid I hope).
No testing was performed.
1/ I was scared to read: "May not have been tested." in one of the classes
2/ Copyright 2004-2006 - shouldn't it be Copyright 2006 only?
3/ The javadoc of classes should be consistent. It means that it should read:
/**
* @goal undeploy (if appropriate)
*
* @version $Rev$ $Date$
*/
whereas some contain
@version $Revision$ $Date$
or no version at all.
4/ Geronimo :: Maven Deployment Plugin using m2 -> Geronimo :: Maven 2
Deployment Plugin or alternatively Geronimo :: Maven Deployment Plugin
for Maven 2, but I'd prefer the former.
5/ geronimo-deployment-plugin/pom.xml has no ASF license header.
So, unless it's corrected I'm -1. If you're swampped with your other
work, I can take care of it and propose the patch corrected again.
> Here's my +1.
It doesn't count, though ;-)
> david jencks
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl