You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/31 08:10:06 UTC
[GitHub] [hive] ArkoSharma opened a new pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
ArkoSharma opened a new pull request #2135:
URL: https://github.com/apache/hive/pull/2135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630741577
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
private String dumpDir;
private long numEvents;
private long eventSeqNo;
+ private long currentEventTimestamp;
Review comment:
Is there some other recommendation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r631596465
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
private String dumpDir;
private long numEvents;
private long eventSeqNo;
+ private long currentEventTimestamp;
Review comment:
The concern here is that the timing for first event is not accurate. It may be quite a while from the point where ReplLoadWork (which is the start time for first event in your patch) till it actually get started. And additionally this will also impact the other metrics which may add on per type basis in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630477224
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
private String dumpDir;
private long numEvents;
private long eventSeqNo;
+ private long currentEventTimestamp;
Review comment:
Tracking the timing inside the logger may not be a great idea. Time taken for an event should be an input given to the logger from outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630468790
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -681,6 +682,7 @@ private int executeIncrementalLoad() throws Exception {
}
this.childTasks.addAll(childTasks);
createReplLoadCompleteAckTask();
+ LOG.info("REPL_INCREMENTAL_LOAD duration : {} ms", System.currentTimeMillis() - loadStartTime);
Review comment:
Does schedule instance ID gets printed here? If not how do we related this message to the policy?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
private String dumpDir;
private long numEvents;
private long eventSeqNo;
+ private long currentEventTimestamp;
Review comment:
Tracking the timing insider the logger may not be a great idea. Time taken for an event should be an input given to the logger from outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630735633
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -681,6 +682,7 @@ private int executeIncrementalLoad() throws Exception {
}
this.childTasks.addAll(childTasks);
createReplLoadCompleteAckTask();
+ LOG.info("REPL_INCREMENTAL_LOAD duration : {} ms", System.currentTimeMillis() - loadStartTime);
Review comment:
Yes, the execution-id gets printed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ArkoSharma commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
ArkoSharma commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630740615
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
private String dumpDir;
private long numEvents;
private long eventSeqNo;
+ private long currentEventTimestamp;
Review comment:
The intention was to maintain the timestamp in barrier tasks. The barrier task gets executed once all the tasks for one event finish. So the difference between consecutive barrier-timestamps gives duration for one event plus additional time of processing the previous barrier. In this case, the logger (ReplStateLogTask) happens to be the barrier task so it is maintained here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha merged pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…
Posted by GitBox <gi...@apache.org>.
pkumarsinha merged pull request #2135:
URL: https://github.com/apache/hive/pull/2135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org