You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "martin-g (via GitHub)" <gi...@apache.org> on 2025/10/27 20:13:16 UTC
[PR] [Variant] Fix the index of an item in VariantArray in a unit test [arrow-rs]
martin-g opened a new pull request, #8725:
URL: https://github.com/apache/arrow-rs/pull/8725
# Which issue does this PR close?
Related-to: #8625
# Rationale for this change
https://github.com/apache/arrow-rs/commit/63fe99a826c6861d9398850671ab88f1571a092d introduced the new unit test.
I believe the index=3 is a typo. It should be =2.
# What changes are included in this PR?
Fixed the array index.
# Are these changes tested?
The fix is in a unit test.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Variant] Fix the index of an item in VariantArray in a unit test [arrow-rs]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #8725:
URL: https://github.com/apache/arrow-rs/pull/8725#issuecomment-3458366729
> I wonder why calling `is_null(3)`didn't panic
It does not panic because it does not use the index at all. `.nulls()` returns `None` and thus it does not use the index. The assert() passes because of the negation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Variant] Fix the index of an item in VariantArray in a unit test [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8725:
URL: https://github.com/apache/arrow-rs/pull/8725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Variant] Fix the index of an item in VariantArray in a unit test [arrow-rs]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #8725:
URL: https://github.com/apache/arrow-rs/pull/8725#issuecomment-3453122513
CC @friendlymatthew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org