You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by "gtoison (via GitHub)" <gi...@apache.org> on 2023/02/10 12:23:14 UTC
[GitHub] [poi] gtoison opened a new pull request, #428: Performance improvements when writing many cells with SXSSF
gtoison opened a new pull request, #428:
URL: https://github.com/apache/poi/pull/428
SXSSFCell.getColumnIndex() gets slow when writing thousands of columns because we linearly search through all the cells in a row.
Since the column index is already known when creating a new cell we can just use it to track the left/right most column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] gtoison commented on pull request #428: Performance improvements when writing many cells with SXSSF
Posted by "gtoison (via GitHub)" <gi...@apache.org>.
gtoison commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425835852
Ah that's great! Indeed I noticed the performance problem using 5.2.3 but did not see that some improvements were made
Thanks to the changes I suppose that this PR is not needed.
Unless you want to merge it anyway I will close the PR, let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] gtoison commented on pull request #428: Performance improvements when writing many cells with SXSSF
Posted by "gtoison (via GitHub)" <gi...@apache.org>.
gtoison commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425902041
I've tested the snapshot build and it seems better indeed, looking forward to 5.2.4!
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #428: Performance improvements when writing many cells with SXSSF
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425874890
I don't to want to merge this - can you close it? I think the existing changes are sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] gtoison closed pull request #428: Performance improvements when writing many cells with SXSSF
Posted by "gtoison (via GitHub)" <gi...@apache.org>.
gtoison closed pull request #428: Performance improvements when writing many cells with SXSSF
URL: https://github.com/apache/poi/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #428: Performance improvements when writing many cells with SXSSF
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425758240
* `new SXSSFCell(this, type, column)` sets _columnIndex
* getColumIndex() uses _columnIndex and only searches the row if _columnIndex is not set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org