You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rkennedy-mode (via GitHub)" <gi...@apache.org> on 2023/09/27 19:35:56 UTC

[GitHub] [arrow] rkennedy-mode commented on issue #37892: Offer an un-shaded version of the Flight SQL JDBC driver

rkennedy-mode commented on issue #37892:
URL: https://github.com/apache/arrow/issues/37892#issuecomment-1737968363

   As a test, I made the following change to the `flight-sql-jdbc-driver` POM:
   
   ```diff
   diff --git a/java/flight/flight-sql-jdbc-driver/pom.xml b/java/flight/flight-sql-jdbc-driver/pom.xml
   index 1fd9222be..08e47187f 100644
   --- a/java/flight/flight-sql-jdbc-driver/pom.xml
   +++ b/java/flight/flight-sql-jdbc-driver/pom.xml
   @@ -172,7 +172,8 @@
                                <goal>shade</goal>
                            </goals>
                            <configuration>
   -                            <shadedArtifactAttached>false</shadedArtifactAttached>
   +                            <shadedArtifactAttached>true</shadedArtifactAttached>
   +                            <shadedClassifierName>shaded</shadedClassifierName>
                                <createDependencyReducedPom>false</createDependencyReducedPom>
                                <minimizeJar>false</minimizeJar>
                                <artifactSet>
   ```
   
   I then built the entire Java tree with the following command:
   
   ```
   JAVA_HOME=/usr/lib/jvm/java-8-openjdk-arm64 mvn -Dmaven.repo.local=/tmp/arrow/.maven_repo clean install
   ```
   
   Looking in the local Maven repository, I see the following:
   
   ```
   root@0a9e22d01fcb:/tmp/arrow/java# ls -l ../.maven_repo/org/apache/arrow/flight-sql-jdbc-driver/14.0.0-SNAPSHOT/
   total 35416
   -rw-r--r-- 1 root root      444 Sep 27 17:57 _remote.repositories
   -rw-r--r-- 1 root root   125160 Sep 27 17:56 flight-sql-jdbc-driver-14.0.0-SNAPSHOT-cyclonedx.json
   -rw-r--r-- 1 root root   111299 Sep 27 17:56 flight-sql-jdbc-driver-14.0.0-SNAPSHOT-cyclonedx.xml
   -rw-r--r-- 1 root root 35978036 Sep 27 17:57 flight-sql-jdbc-driver-14.0.0-SNAPSHOT-shaded.jar
   -rw-r--r-- 1 root root    10394 Sep 27 17:56 flight-sql-jdbc-driver-14.0.0-SNAPSHOT-tests.jar
   -rw-r--r-- 1 root root    11230 Sep 27 17:56 flight-sql-jdbc-driver-14.0.0-SNAPSHOT.jar
   -rw-r--r-- 1 root root    10716 Sep 27 17:40 flight-sql-jdbc-driver-14.0.0-SNAPSHOT.pom
   -rw-r--r-- 1 root root     1553 Sep 27 17:57 maven-metadata-local.xml
   ```
   
   This seems pretty workable for most people. Folks using Maven/Gradle/whatever to manage their projects would switch to pulling the un-shaded artifact and its corresponding dependencies. Folks needing the shaded JAR would have to start specifying the `shaded` classifier to get that artifact, instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org