You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/18 18:01:52 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #8962: [ShadeTest]Add integration shade test for pulsar-client and pulsar-cient-admin.

merlimat commented on a change in pull request #8962:
URL: https://github.com/apache/pulsar/pull/8962#discussion_r545998010



##########
File path: pulsar-client-shaded/pom.xml
##########
@@ -104,6 +104,7 @@
               <artifactSet>
                 <includes>
                   <include>org.apache.pulsar:pulsar-client-original</include>
+                  <include>org.apache.pulsar:pulsar-client-api</include>

Review comment:
       The client api is meant to not get included in the shaded artifact, otherwise IDEs will not be able to fetch the sources and javadoc for the client APIs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org