You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/03 11:47:50 UTC
[GitHub] [cordova-plugin-network-information] ghenry22 opened a new pull
request #98: (android) Fix Startup crash on Android 10 devices
ghenry22 opened a new pull request #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98
### Platforms affected
Android
### Motivation and Context
Before change: install cordova-plugin-network-information, run on emulator or device with Android 10. App crashes on start up.
After change: app runs normally on Android 10.
### Description
change path to appmanifest file. Without this change app will crash on startup on Android 10. Can reproduce easily on either emulator or device.
### Testing
Ran on a variety of emulators and test devices. Before crash on start. After runs normally.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [X ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] ghenry22 commented on issue
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
ghenry22 commented on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-570577830
@timbru31 I am using Cordova 9 and android 8.1.0 and still had this issue until this fix so that is unusual. If it’s fixed then no matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] timbru31 commented on issue
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-570597150
That's strange. What's your output of `npm ls cordova-common` in your project? It should be resolved to `3.2.1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] timbru31 commented on issue
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-572621308
Glad to hear it self-healed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] timbru31 commented on issue
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-570573977
Thanks a lot for your PR, however the underlying issue is already fixed and released in cordova-common (https://github.com/apache/cordova-common/pull/89). Please make sure to use cordova@9 and cordova-android@8.1.0 when building the app.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] ghenry22 commented on issue
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
ghenry22 commented on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-572603658
@timbru31 seems like cordova-common hadn't updated for some reason, running npm install -g cordova again it updated and all looks good now. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] tryhardest edited a comment on
issue #98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
tryhardest edited a comment on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-578453793
@timbru31 at the bottom of apache/cordova-common#89 you can see some open issues on permission related issues. We also are on 9 with 8.1.0 and experience same issues that our permission primers no longer pass to native permission. Any idea on this config.xml overwrite conflict it seems related too? As per https://github.com/apache/cordova-plugin-camera/issues/486 cc @liuxiaoy @raphinesse @dminkovsky
Going to try with @nightly will report back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] tryhardest commented on issue
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
tryhardest commented on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-578453793
@timbru31 at the bottom of apache/cordova-common#89 you can see some open issues on permission related issues. We also are on 9 with 8.1.0 and experience same issues that our permission primers no longer pass to native permission. Any idea on this config.xml overwrite conflict it seems related too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] tryhardest edited a comment on
issue #98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
tryhardest edited a comment on issue #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98#issuecomment-578453793
@timbru31 at the bottom of apache/cordova-common#89 you can see some open issues on permission related issues. We also are on 9 with 8.1.0 and experience same issues that our permission primers no longer pass to native permission. Any idea on this config.xml overwrite conflict it seems related too? As per https://github.com/apache/cordova-plugin-camera/issues/486 cc @liuxiaoy @raphinesse @dminkovsky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] timbru31 closed pull request
#98: (android) Fix Startup crash on Android 10 devices
Posted by GitBox <gi...@apache.org>.
timbru31 closed pull request #98: (android) Fix Startup crash on Android 10 devices
URL: https://github.com/apache/cordova-plugin-network-information/pull/98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org