You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/07 06:00:39 UTC
[GitHub] [flink] wuchong opened a new pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
wuchong opened a new pull request #14572:
URL: https://github.com/apache/flink/pull/14572
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, the BytesHashMap and BytesMultiMap only support BinaryRowData as the key. However, for window operators, the key should be groupKey + window. We should make them decouple with BinaryRowData key type and support window key.
## Brief change log
0. Move `BytesMap` classes to util packag. Because in the near future, the structures will not only be used in aggregations, but also topn and others.
2. Extract pages operations from `AbstractRowDataSerializer` into `PagedTypeSerializer`
1. Make `BytesMap` decouple with `BinaryRowData` key type
3. Introduce `WindowKey` structure and `WindowKeySerializer`
4. Introduce `BytesWindowHashMap` and `BytesWindowMultiMap` to support window key
We still keep the original name of `BytesHashMap` unchanged to avoid changing too many codes.
## Verifying this change
Refactor `BytesHashMapTest` and `BytesMultiMapTest` tests to also cover the new introduced `BytesWindowHashMap` and `BytesWindowMultiMap`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (**yes** / no / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f1d5189abe80623eba977235da6969663b535dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #14572:
URL: https://github.com/apache/flink/pull/14572#discussion_r553706628
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryRowDataSerializer.java
##########
@@ -197,6 +197,11 @@ public BinaryRowData mapFromPages(BinaryRowData reuse, AbstractPagedInputView he
return reuse;
}
+ @Override
+ public void skipRecordToRead(AbstractPagedInputView source) throws IOException {
+ source.skipBytes(source.readInt());
Review comment:
Why not `checkSkipReadForFixLengthPart`?
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryRowDataSerializer.java
##########
@@ -197,6 +197,11 @@ public BinaryRowData mapFromPages(BinaryRowData reuse, AbstractPagedInputView he
return reuse;
}
+ @Override
+ public void skipRecordToRead(AbstractPagedInputView source) throws IOException {
Review comment:
A better name to remind `pages`?
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/util/collections/binary/BytesMap.java
##########
@@ -182,9 +176,8 @@ public void reset() {
* BinaryRowData form who has only one MemorySegment.
* @return {@link LookupInfo}
*/
- public LookupInfo<V> lookup(BinaryRowData key) {
- // check the looking up key having only one memory segment
- checkArgument(key.getSegments().length == 1);
+ public LookupInfo<K, V> lookup(K key) {
+ validateKey(key);
Review comment:
That is legacy code, we don't need to validate it now.
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/PagedTypeSerializer.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.typeutils;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.runtime.memory.AbstractPagedInputView;
+import org.apache.flink.runtime.memory.AbstractPagedOutputView;
+import org.apache.flink.table.data.binary.BinaryRowData;
+
+import java.io.IOException;
+
+/** A type serializer which provides paged serialize and deserialize methods. */
+@Internal
+public abstract class PagedTypeSerializer<T> extends TypeSerializer<T> {
+
+ private static final long serialVersionUID = 1L;
+
+ /**
+ * Serializes the given record to the given target paged output view. Some implementations may
+ * skip some bytes if current page does not have enough space left, .e.g {@link BinaryRowData}.
+ *
+ * @param record The record to serialize.
+ * @param target The output view to write the serialized data to.
+ * @return Returns the skipped number of bytes.
+ * @throws IOException Thrown, if the serialization encountered an I/O related error. Typically
+ * raised by the output view, which may have an underlying I/O channel to which it
+ * delegates.
+ */
+ public abstract int serializeToPages(T record, AbstractPagedOutputView target)
+ throws IOException;
+
+ /**
+ * De-serializes a record from the given source paged input view. For consistency with serialize
+ * format, some implementations may need to skip some bytes of source before de-serializing,
+ * .e.g {@link BinaryRowData}. Typically, the content read from source should be copied out when
+ * de-serializing, and we are not expecting the underlying data from source is reused. If you
+ * have such requirement, see {@link #mapFromPages(AbstractPagedInputView)}.
+ *
+ * @param source The input view from which to read the data.
+ * @return The de-serialized element.
+ * @throws IOException Thrown, if the de-serialization encountered an I/O related error.
+ * Typically raised by the input view, which may have an underlying I/O channel from which
+ * it reads.
+ */
+ public abstract T deserializeFromPages(AbstractPagedInputView source) throws IOException;
+
+ /** Reuse version of {@link #deserializeFromPages(AbstractPagedInputView)}. */
+ public abstract T deserializeFromPages(T reuse, AbstractPagedInputView source)
+ throws IOException;
+
+ /**
+ * Map a record from the given source paged input view. This method provides a possibility to
+ * achieve zero copy when de-serializing. You can either choose copy or not copy the content
+ * read from source, but we encourage to make it zero copy.
+ *
+ * <p>If you choose the zero copy way, you have to deal with the lifecycle of the pages
+ * properly.
+ *
+ * @param source The input view from which to read the data.
+ * @return The mapped element.
+ * @throws IOException Thrown, if the de-serialization encountered an I/O related error.
+ * Typically raised by the input view, which may have an underlying I/O channel from which
+ * it reads.
+ */
+ public abstract T mapFromPages(AbstractPagedInputView source) throws IOException;
Review comment:
Can you remove this method? It is useless but misleading.
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/util/collections/binary/BytesWindowHashMap.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.util.collections.binary;
+
+import org.apache.flink.runtime.memory.MemoryManager;
+import org.apache.flink.table.runtime.typeutils.WindowKeySerializer;
+import org.apache.flink.table.runtime.util.WindowKey;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import static org.apache.flink.util.Preconditions.checkArgument;
+
+/**
+ * A binary map in the structure like {@code Map<WindowKey, BinaryRowData>}.
+ *
+ * @see BytesHashMapBase for more information about the binary layout.
+ */
+public final class BytesWindowHashMap extends BytesHashMapBase<WindowKey> {
Review comment:
NIT: I prefer `WindowBytesHashMap`, corresponding to `AbstractBytesHashMap`
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/util/collections/binary/BytesHashMapBase.java
##########
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.util.collections.binary;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.core.memory.MemorySegment;
+import org.apache.flink.core.memory.MemorySegmentFactory;
+import org.apache.flink.runtime.io.disk.RandomAccessInputView;
+import org.apache.flink.runtime.io.disk.SimpleCollectingOutputView;
+import org.apache.flink.runtime.memory.AbstractPagedInputView;
+import org.apache.flink.runtime.memory.MemoryManager;
+import org.apache.flink.table.data.binary.BinaryRowData;
+import org.apache.flink.table.runtime.typeutils.BinaryRowDataSerializer;
+import org.apache.flink.table.runtime.typeutils.PagedTypeSerializer;
+import org.apache.flink.table.runtime.util.KeyValueIterator;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.util.MathUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.EOFException;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.util.Preconditions.checkArgument;
+
+/**
+ * Bytes based hash map. It can be used for performing aggregations where the aggregated values are
+ * fixed-width, because the data is stored in continuous memory, AggBuffer of variable length cannot
+ * be applied to this HashMap. The KeyValue form in hash map is designed to reduce the cost of key
+ * fetching in lookup. The memory is divided into two areas:
+ *
+ * <p>Bucket area: pointer + hashcode.
+ *
+ * <ul>
+ * <li>Bytes 0 to 4: a pointer to the record in the record area
+ * <li>Bytes 4 to 8: key's full 32-bit hashcode
+ * </ul>
+ *
+ * <p>Record area: the actual data in linked list records, a record has four parts:
+ *
+ * <ul>
+ * <li>Bytes 0 to 4: len(k)
+ * <li>Bytes 4 to 4 + len(k): key data
+ * <li>Bytes 4 + len(k) to 8 + len(k): len(v)
+ * <li>Bytes 8 + len(k) to 8 + len(k) + len(v): value data
+ * </ul>
+ *
+ * <p>{@code BytesHashMap} are influenced by Apache Spark BytesToBytesMap.
+ */
+public abstract class BytesHashMapBase<K> extends BytesMap<K, BinaryRowData> {
Review comment:
NIT: I prefer `AbstractBytesHashMap`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #14572:
URL: https://github.com/apache/flink/pull/14572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f1d5189abe80623eba977235da6969663b535dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
}, {
"hash" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f1d5189abe80623eba977235da6969663b535dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719)
* 5f2c9f1f5ae08d469519ceea65208fd30d113866 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755905594
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3f1d5189abe80623eba977235da6969663b535dc (Thu Jan 07 06:02:39 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-756626502
Thanks @JingsongLi for the reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
}, {
"hash" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723",
"triggerID" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f1d5189abe80623eba977235da6969663b535dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719)
* 5f2c9f1f5ae08d469519ceea65208fd30d113866 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-756626502
Thanks @JingsongLi for the reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
}, {
"hash" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723",
"triggerID" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"triggerType" : "PUSH"
}, {
"hash" : "239362ad20e726dc266bd7b3c6949991210cd264",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11778",
"triggerID" : "239362ad20e726dc266bd7b3c6949991210cd264",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f2c9f1f5ae08d469519ceea65208fd30d113866 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723)
* 239362ad20e726dc266bd7b3c6949991210cd264 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11778)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
}, {
"hash" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723",
"triggerID" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"triggerType" : "PUSH"
}, {
"hash" : "239362ad20e726dc266bd7b3c6949991210cd264",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "239362ad20e726dc266bd7b3c6949991210cd264",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f2c9f1f5ae08d469519ceea65208fd30d113866 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723)
* 239362ad20e726dc266bd7b3c6949991210cd264 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-756534506
Thanks for the review @JingsongLi . I have addressed the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755905594
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 239362ad20e726dc266bd7b3c6949991210cd264 (Fri May 28 07:02:46 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #14572:
URL: https://github.com/apache/flink/pull/14572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14572: [FLINK-20877][table-runtime-blink] Refactor BytesHashMap and BytesMultiMap to support window key
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14572:
URL: https://github.com/apache/flink/pull/14572#issuecomment-755910110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f1d5189abe80623eba977235da6969663b535dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11719",
"triggerID" : "3f1d5189abe80623eba977235da6969663b535dc",
"triggerType" : "PUSH"
}, {
"hash" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723",
"triggerID" : "5f2c9f1f5ae08d469519ceea65208fd30d113866",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f2c9f1f5ae08d469519ceea65208fd30d113866 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11723)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org