You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jdye64 (via GitHub)" <gi...@apache.org> on 2023/03/14 22:44:18 UTC
[GitHub] [arrow-datafusion-python] jdye64 opened a new pull request, #281: Add conda.yaml baseline workflow file
jdye64 opened a new pull request, #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281
# Which issue does this PR close?
Closes #280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] charlesbluca commented on a diff in pull request #281: Add conda.yaml baseline workflow file
Posted by "charlesbluca (via GitHub)" <gi...@apache.org>.
charlesbluca commented on code in PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281#discussion_r1173102287
##########
conda/recipes/meta.yaml:
##########
@@ -15,32 +15,41 @@
# specific language governing permissions and limitations
# under the License.
-{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
-{% set minor_version = version.split('.')[0] + '.' + version.split('.')[1] %}
+{% set name = "datafusion" %}
+{% set major_minor_patch = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').split('.') %}
+{% set new_patch = major_minor_patch[2] | int + 1 %}
+{% set version = (major_minor_patch[:2] + [new_patch]) | join('.') + environ.get('VERSION_SUFFIX', '') %}
+
package:
- name: datafusion
+ name: {{ name|lower }}
version: {{ version }}
source:
git_url: ../..
build:
noarch: python
Review Comment:
Do we have a preference for what platforms we want to build and publish for? Don't need to do those builds here, but if we intend to publish to conda-forge it's likely that we'll need to cross compile for Mac and Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on a diff in pull request #281: Add conda.yaml baseline workflow file
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on code in PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281#discussion_r1174617314
##########
conda/recipes/meta.yaml:
##########
@@ -15,32 +15,41 @@
# specific language governing permissions and limitations
# under the License.
-{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
-{% set minor_version = version.split('.')[0] + '.' + version.split('.')[1] %}
+{% set name = "datafusion" %}
+{% set major_minor_patch = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').split('.') %}
+{% set new_patch = major_minor_patch[2] | int + 1 %}
+{% set version = (major_minor_patch[:2] + [new_patch]) | join('.') + environ.get('VERSION_SUFFIX', '') %}
+
package:
- name: datafusion
+ name: {{ name|lower }}
version: {{ version }}
source:
git_url: ../..
build:
noarch: python
Review Comment:
Yeah, I think that covers the main ones. Let me make another PR after this one for conda macOS arm64 builds. Will do that after this PR merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #281: Add conda.yaml baseline workflow file
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281#issuecomment-1516659262
@andygrove could you approve @charlesbluca so CI can run his commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] mbrobbel commented on pull request #281: Add conda.yaml baseline workflow file
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281#issuecomment-1469731188
@jdye64 I created https://github.com/oxidecomputer/typify/pull/221. Hopefully this helps with building the `substrait` crate in environments without `rustfmt` available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #281: Add conda.yaml baseline workflow file
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281#issuecomment-1470027403
> @jdye64 I created [oxidecomputer/typify#221](https://github.com/oxidecomputer/typify/pull/221). Hopefully this helps with building the `substrait` crate in environments without `rustfmt` available.
Thank you for noticing my trail of pain in the commit messages and opening that PR @mbrobbel haha. I appreciate it. I kept getting so close and just something about the virtual conda build environment that gets created just will not find that appropriate installation of `rustfmt` no matter what I try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #281: Add conda.yaml baseline workflow file
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281#discussion_r1174598151
##########
conda/recipes/meta.yaml:
##########
@@ -15,32 +15,41 @@
# specific language governing permissions and limitations
# under the License.
-{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
-{% set minor_version = version.split('.')[0] + '.' + version.split('.')[1] %}
+{% set name = "datafusion" %}
+{% set major_minor_patch = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').split('.') %}
+{% set new_patch = major_minor_patch[2] | int + 1 %}
+{% set version = (major_minor_patch[:2] + [new_patch]) | join('.') + environ.get('VERSION_SUFFIX', '') %}
+
package:
- name: datafusion
+ name: {{ name|lower }}
version: {{ version }}
source:
git_url: ../..
build:
noarch: python
Review Comment:
CI currently builds the following wheels that we upload to PyPi:
```
datafusion-22.0.0-cp37-abi3-macosx_10_7_x86_64.whl
datafusion-22.0.0-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
datafusion-22.0.0-cp37-abi3-win_amd64.whl
```
I am building the macos arm64 wheel manually but would love to get that automated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #281: Add conda.yaml baseline workflow file
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #281:
URL: https://github.com/apache/arrow-datafusion-python/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org