You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by ch...@apache.org on 2006/10/03 08:29:13 UTC
svn commit: r452320 - in /webservices/axis2/trunk/java/modules:
adb/src/org/apache/axis2/databinding/types/
kernel/src/org/apache/axis2/addressing/ kernel/src/org/apache/axis2/util/
samples/src/sample/eventing/
Author: chinthaka
Date: Mon Oct 2 23:29:12 2006
New Revision: 452320
URL: http://svn.apache.org/viewvc?view=rev&rev=452320
Log:
Improving Strings handling. When u use buffers to improve String handling and if u use string concat inside them, then you are losing your objective.
Modified:
webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/databinding/types/Duration.java
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/EndpointReference.java
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java
webservices/axis2/trunk/java/modules/samples/src/sample/eventing/PublisherService.java
Modified: webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/databinding/types/Duration.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/databinding/types/Duration.java?view=diff&rev=452320&r1=452319&r2=452320
==============================================================================
--- webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/databinding/types/Duration.java (original)
+++ webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/databinding/types/Duration.java Mon Oct 2 23:29:12 2006
@@ -383,30 +383,30 @@
duration.append("P");
if (years != 0) {
- duration.append(years + "Y");
+ duration.append(years).append("Y");
}
if (months != 0) {
- duration.append(months + "M");
+ duration.append(months).append("M");
}
if (days != 0) {
- duration.append(days + "D");
+ duration.append(days).append("D");
}
if (hours != 0 || minutes != 0 || seconds != 0.0) {
duration.append("T");
if (hours != 0) {
- duration.append(hours + "H");
+ duration.append(hours).append("H");
}
if (minutes != 0) {
- duration.append(minutes + "M");
+ duration.append(minutes).append("M");
}
if (seconds != 0) {
if (seconds == (int) seconds) {
- duration.append((int) seconds + "S");
+ duration.append((int) seconds).append("S");
} else {
- duration.append(seconds + "S");
+ duration.append(seconds).append("S");
}
}
}
Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/EndpointReference.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/EndpointReference.java?view=diff&rev=452320&r1=452319&r2=452320
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/EndpointReference.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/EndpointReference.java Mon Oct 2 23:29:12 2006
@@ -245,16 +245,16 @@
StringBuffer buffer = new StringBuffer("Address: " + address);
if (metaData != null)
- buffer.append(", Metadata: " + metaData);
-
+ buffer.append(", Metadata: ").append(metaData);
+
if (referenceParameters != null)
- buffer.append(", Reference Parameters: " + referenceParameters);
+ buffer.append(", Reference Parameters: ").append(referenceParameters);
if (extensibleElements != null)
- buffer.append(", Extensibility elements: " + extensibleElements);
+ buffer.append(", Extensibility elements: ").append(extensibleElements);
if (attributes != null)
- buffer.append(", Attributes: " + attributes);
+ buffer.append(", Attributes: ").append(attributes);
return buffer.toString();
}
Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java?view=diff&rev=452320&r1=452319&r2=452320
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java Mon Oct 2 23:29:12 2006
@@ -111,13 +111,13 @@
// The identifier cannot be mapped strictly according to
// JSR 101
if (Character.isJavaIdentifierPart(nameArray[0])) {
- result.append("_" + nameArray[0]);
+ result.append("_").append(nameArray[0]);
}
else {
// The XML identifier does not contain any characters
// we can map to Java. Using the length of the string
// will make it somewhat unique.
- result.append("_" + nameArray.length);
+ result.append("_").append(nameArray.length);
}
}
Modified: webservices/axis2/trunk/java/modules/samples/src/sample/eventing/PublisherService.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/samples/src/sample/eventing/PublisherService.java?view=diff&rev=452320&r1=452319&r2=452320
==============================================================================
--- webservices/axis2/trunk/java/modules/samples/src/sample/eventing/PublisherService.java (original)
+++ webservices/axis2/trunk/java/modules/samples/src/sample/eventing/PublisherService.java Mon Oct 2 23:29:12 2006
@@ -80,7 +80,7 @@
OMElement publicationElement = factory.createOMElement(Publication,namespace);
int value = r.nextInt();
- publicationElement.setText(new Integer(value).toString());
+ publicationElement.setText(Integer.toString(value));
OMElement publishMethod = factory.createOMElement("publish",namespace);
publishMethod.addChild(publicationElement);
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org