[jira] Commented: (UIMA-1129) XMI serialization support for delta CAS

["Thilo Goetz (JIRA)" <ui...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/UIMA-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625281#action_12625281 ] 

Thilo Goetz commented on UIMA-1129:
-----------------------------------

Some things I noticed looking at the patch:

* I thought this option would be enabled by a performance tuning option.  I don't see that in the patch, maybe I missed it.

* There should be a boolean member variable "deltaCasEnabled" or something like that.  This should be used in the code for checking this condition, so it's clear what's going on (and easier to change in case the implementation changes).  It's also faster.

* this.svd.modifiedPreexistingFSs should only be initialised if deltaCasEnabled.  We want to keep the CAS reset overhead as small as possible.

* There should be no public createMarker() API, see above.

* What's the point of having a marker interface if the XmiCasSerializer uses the MarkerImpl?  Either make the interface so specific that the XmiCasSerializer can use it, or dispense with the interface altogether.  I would vote for not having public interfaces for this.  In the CAS you insert a new public API, then say "don't use it".  Why?  Just keep this implementation internal.




> XMI serialization support for delta CAS  
> -----------------------------------------
>
>                 Key: UIMA-1129
>                 URL: https://issues.apache.org/jira/browse/UIMA-1129
>             Project: UIMA
>          Issue Type: New Feature
>          Components: Core Java Framework
>            Reporter: Bhavani Iyer
>            Assignee: Bhavani Iyer
>         Attachments: UIMA-1129.patch
>
>
> Extend XMI serialization to enable serializing only the changes to the CAS.  The requirement for delta CAS support in order to to reduce serialization overhead associated with remote services is described in the wiki page found here: http://cwiki.apache.org/UIMA/reducing-overhead-for-remote-service-calls.html.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.