You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:00:41 UTC
[GitHub] [skywalking] BFergerson opened a new issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
BFergerson opened a new issue #7113:
URL: https://github.com/apache/skywalking/issues/7113
Why do you submit this issue?
- [x] Feature or performance improvement
___
### Requirement or improvement
You can use "Group Parameterized Endpoints" to collapse endpoint `/users/10` and `/users/100` but it doesn't differentiate between HTTP method types so doing a `{GET}]/users/10` looks the same as `{DELETE}/users/10`.
I've created a patch that adds the HTTP method type before the URL but I'm curious if anyone knows whether to dynamic endpoint can also be determined. That's the `/users/{id}` part that's defined in `@RequestMapping`. My guess is you can't since Tomcat sits a layer above SpringMVC. If that's the case, could you update an entry span's operation name? I ask because I would rather auto-detect this information than create the necessary `endpoint-name-grouping.yml` file. I like that that file exists but I think it's best to consider it as a last result.
If neither method works, is there a way to implement something like `USE_QUALIFIED_NAME_AS_ENDPOINT_NAME` like SpringMVC or is that again an issue because Tomcat sits above SpringMVC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] onurccn commented on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
onurccn commented on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-891968014
@wu-sheng OpenAPI supported but TomcatInvokeInterceptor still creates spans with just URI. Should we re-open and fix that naming as [HTTP Method + ':' + URI] ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-860008718
@BFergerson Codes like `RequestMappingMethodInterceptor#getAcceptedMethodTypes`, I think we need some adjustment, to follow the same name pattern like this
https://github.com/apache/skywalking/blob/efcb396f7338265f0b1e05f1a512dcd65773c538/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java#L129-L136
Meaning, remove `<` and `>`.
Also, I think we need to discuss whether we should keep runtime HTTP method rather than declaration level methods, only the latter could be multiple values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] BFergerson commented on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
BFergerson commented on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-859973371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-892250399
I think this has not supported. Right now, you could activate the http method in the span name, but not separate by colon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-864478726
OpenAPI has been supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-892251630
#7135 is what you ask for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-859972266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7113:
URL: https://github.com/apache/skywalking/issues/7113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #7113: TomcatInvokeInterceptor doesn't include HTTP method in endpoint name
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-892250399
I think this has not been supported. Right now, you could activate the HTTP method in the span name in SpringMVC plugin only, but not separate by a colon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org