[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #6500: [ISSUE #6355] Add logback placeholder default value to avoid brokerLogDir_IS_UNDEFINED

["aaron-ai (via GitHub)" <gi...@apache.org>]

aaron-ai commented on code in PR #6500:
URL: https://github.com/apache/rocketmq/pull/6500#discussion_r1152641267


##########
proxy/src/main/resources/rmq.proxy.logback.xml:
##########
@@ -63,10 +63,12 @@
     <!-- Below is the logger configuration for broker-->
     <appender name="DefaultAppender"
               class="ch.qos.logback.core.rolling.RollingFileAppender">
-        <file>${user.home}/logs/rocketmqlogs/${brokerLogDir}/broker_default.log</file>
+        <file>${user.home}/logs/rocketmqlogs/${brokerLogDir:-${file.separator}}/broker_default.log</file>

Review Comment:
   Why not replace all `/` with `${file.separator}`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org