You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/04 21:58:19 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new issue #6644: Adding validation check to prevent creating two columns with different cases in schema
fx19880617 opened a new issue #6644:
URL: https://github.com/apache/incubator-pinot/issues/6644
Although pinot columns can be case-sensitive, I think we should still prevent the scenarios like this.
This easily breaks the external case-insensitive integrations like Presto.
E.g. in the same schema, we shouldn't allow creating two columns like: `memberId` and `MemberID`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] icefury71 commented on issue #6644: Adding validation check to prevent creating two columns with different cases in schema
Posted by GitBox <gi...@apache.org>.
icefury71 commented on issue #6644:
URL: https://github.com/apache/incubator-pinot/issues/6644#issuecomment-790983268
Yes agreed - this one in particular seems to be backwards incompatible. Currently, we don't provide a mechanism to enforce different levels of validation. We should probably get that done before adding such checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #6644: Adding validation check to prevent creating two columns with different cases in schema
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on issue #6644:
URL: https://github.com/apache/incubator-pinot/issues/6644#issuecomment-790976508
I am fine for adding all sorts of validations, but I thought we agreed (perhaps verbally) on doing things in a compatible manner by introducing the concept of a `level`. If the level is set to "strict" then we can do all stuff.
This change, in particular, is backwards incompatible. It is impossible to check thousands of tables for each condition.
cc: @kishoreg , @icefury71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] icefury71 commented on issue #6644: Adding validation check to prevent creating two columns with different cases in schema
Posted by GitBox <gi...@apache.org>.
icefury71 commented on issue #6644:
URL: https://github.com/apache/incubator-pinot/issues/6644#issuecomment-790985354
@mcvsubbu created #6645 which should be done before addressing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org