You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/07/08 03:15:36 UTC

[GitHub] [hbase] lzx404243 commented on a change in pull request #2984: HBASE-25680 Non-idempotent test in TestReplicationHFileCleaner

lzx404243 commented on a change in pull request #2984:
URL: https://github.com/apache/hbase/pull/2984#discussion_r665839649



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java
##########
@@ -146,6 +147,7 @@ public void testIsFileDeletable() throws IOException, ReplicationException {
     assertFalse("Cleaner should not allow to delete this file as there is a hfile reference node "
         + "for it in the queue.",
       cleaner.isFileDeletable(fs.getFileStatus(file)));
+    rq.removeHFileRefs(peerId, Arrays.asList("testIsFileDeletableWithNoHFileRefs"));

Review comment:
       That makes sense. Pushed a new commit per your suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org