[GitHub] [airflow] dstandish commented on a change in pull request #20642: Added Hook for Amazon RDS

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #20642:
URL: https://github.com/apache/airflow/pull/20642#discussion_r799750871



##########
File path: airflow/providers/amazon/aws/hooks/rds.py
##########
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Interact with AWS RDS."""
+
+from mypy_boto3_rds import RDSClient

Review comment:
       i think you can / should put this behind a type checking guard
   
   e.g. like here https://github.com/apache/airflow/blob/602abe8394fafe7de54df7e73af56de848cdf617/airflow/lineage/backend.py#L21-L22
   
   and then you quote references to it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org