You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/01 09:37:01 UTC
[jira] [Commented] (OPENMEETINGS-1636) Upgrade AppointmentManager
from HttpClient 3.x to 4.x
[ https://issues.apache.org/jira/browse/OPENMEETINGS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671352#comment-16671352 ]
ASF GitHub Bot commented on OPENMEETINGS-1636:
----------------------------------------------
solomax commented on a change in pull request #12: OPENMEETINGS-1636 Upgrade Caldav4j to 1.0.0-rc.1
URL: https://github.com/apache/openmeetings/pull/12#discussion_r229983483
##########
File path: openmeetings-service/src/main/java/org/apache/openmeetings/service/calendar/caldav/IcalUtils.java
##########
@@ -226,13 +229,17 @@ private Appointment addVEventPropertiestoAppointment(Appointment a, CalendarComp
//If the value of the organizer is an email
if ("mailto".equals(uri.getScheme())) {
String email = uri.getSchemeSpecificPart();
- //Contact or exist and owner
- User org = userDao.getByEmail(email);
- if (org == null) {
- org = userDao.getContact(email, a.getOwner());
- attList.add(createMeetingMember(a, org));
- } else if (!org.getId().equals(a.getOwner().getId())) {
- attList.add(createMeetingMember(a, org));
+
+ organizerEmail = email;
+ if(!email.equals(a.getOwner().getAddress().getEmail())) {
Review comment:
could you modify `if(` to be `if (` (add space character before `(`)
here and later in the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Upgrade AppointmentManager from HttpClient 3.x to 4.x
> -----------------------------------------------------
>
> Key: OPENMEETINGS-1636
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1636
> Project: Openmeetings
> Issue Type: Improvement
> Components: HTML5/Calendar
> Reporter: Ankush Mishra
> Assignee: Ankush Mishra
> Priority: Minor
> Fix For: 4.0.7
>
>
> I had been waiting for [JCR-2406|https://issues.apache.org/jira/browse/JCR-2406] to close. Since, that has been completed for a couple of months, I opened another Issue for CalDAV4j [here|https://github.com/caldav4j/caldav4j/issues/63] , which I will try to first release to the Central Repo soon, with 3.x, after which I will get to work on the migration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)