You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/04/05 13:30:33 UTC

[GitHub] [hudi] slfan1989 commented on a diff in pull request #8360: [HUDI-5389] Remove Hudi Cli Duplicates Code.

slfan1989 commented on code in PR #8360:
URL: https://github.com/apache/hudi/pull/8360#discussion_r1158523764


##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RepairsCommand.java:
##########
@@ -18,7 +18,7 @@
 
 package org.apache.hudi.cli.commands;
 
-import org.apache.hudi.cli.DeDupeType;
+import org.apache.spark.sql.hudi.DeDupeType;
 import org.apache.hudi.cli.HoodieCLI;

Review Comment:
   Thank you for helping to review the code, ! found some duplicate code, I want to improve this part of the code. Do we need to keep `org.apache.hudi.cli.DedupeSparkJob` ? and replace `org.apache.spark.sql.hudi.DedupeSparkJob`, I want to hear your opinion.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org