You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/11/05 15:51:30 UTC
[GitHub] [orc] pgaref opened a new pull request #565: ORC-684: [C++] Make Floating point NaN check more strict
pgaref opened a new pull request #565:
URL: https://github.com/apache/orc/pull/565
What changes were proposed in this pull request?
ORC-636 added an extra check (part of RecordReaderImp) disabling PPD when DoubleColumnStats min, max or sum is a non-Finite number.
However, the check is unnecessarily broad – the way stats are updated, using just sum for the check would suffice.
Why are the changes needed?
Make NAN check for DoubleStats (used for PPD) more strict
How was this patch tested?
TestPredicateLeaf.cc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #565: ORC-684: [C++] Make Floating point NaN check more strict
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #565:
URL: https://github.com/apache/orc/pull/565#issuecomment-722648314
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #565: ORC-684: [C++] Make Floating point NaN check more strict
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #565:
URL: https://github.com/apache/orc/pull/565#issuecomment-722506332
Thank you, @pgaref . Is this a performance issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #565: ORC-684: [C++] Make Floating point NaN check more strict
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #565:
URL: https://github.com/apache/orc/pull/565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org