You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Dilley <jo...@citrix.com> on 2014/08/13 15:49:32 UTC

Review Request 24648: CLOUDSTACK-7310 - don't try and shink a disk in the volume resize test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24648/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUSTACK-7310
    https://issues.apache.org/jira/browse/CLOUSTACK-7310


Repository: cloudstack-git


Description
-------

Neither XenServer or KVM support shinking a disk. Given that we skip running this on VMWare and Hyper-V, this means this part of the test will never pass. I have therefore removed it.


Diffs
-----

  test/integration/smoke/test_volumes.py e2e0d76 

Diff: https://reviews.apache.org/r/24648/diff/


Testing
-------


Thanks,

John Dilley


Re: Review Request 24648: CLOUDSTACK-7310 - don't try and shink a disk in the volume resize test

Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24648/#review50657
-----------------------------------------------------------


Don't submit this one, see review 24696 instead

- John Dilley


On Aug. 13, 2014, 2:22 p.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24648/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 2:22 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7310
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7310
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Neither XenServer or KVM support shinking a disk. Given that we skip running this on VMWare and Hyper-V, this means this part of the test will never pass. I have therefore removed it.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Re: Review Request 24648: CLOUDSTACK-7310 - don't try and shink a disk in the volume resize test

Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24648/#review50655
-----------------------------------------------------------

Ship it!


Ship It!

- anthony xu


On Aug. 13, 2014, 2:22 p.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24648/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 2:22 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7310
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7310
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Neither XenServer or KVM support shinking a disk. Given that we skip running this on VMWare and Hyper-V, this means this part of the test will never pass. I have therefore removed it.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Re: Review Request 24648: CLOUDSTACK-7310 - don't try and shink a disk in the volume resize test

Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24648/
-----------------------------------------------------------

(Updated Aug. 13, 2014, 2:22 p.m.)


Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-7310
    https://issues.apache.org/jira/browse/CLOUDSTACK-7310


Repository: cloudstack-git


Description
-------

Neither XenServer or KVM support shinking a disk. Given that we skip running this on VMWare and Hyper-V, this means this part of the test will never pass. I have therefore removed it.


Diffs
-----

  test/integration/smoke/test_volumes.py e2e0d76 

Diff: https://reviews.apache.org/r/24648/diff/


Testing
-------


Thanks,

John Dilley