You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/18 08:25:33 UTC

[GitHub] [flink] StefanRRichter commented on a change in pull request #9138: [FLINK-13249][runtime] Fix handling of partition producer responses b…

StefanRRichter commented on a change in pull request #9138: [FLINK-13249][runtime] Fix handling of partition producer responses b…
URL: https://github.com/apache/flink/pull/9138#discussion_r304793316
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -601,8 +601,7 @@ void notifyChannelNonEmpty(InputChannel channel) {
 	void triggerPartitionStateCheck(ResultPartitionID partitionId) {
 		partitionProducerStateProvider.requestPartitionProducerState(
 			consumedResultId,
-			partitionId)
-			.thenAccept(responseHandle -> {
+			partitionId, (responseHandle -> {
 
 Review comment:
   Agree with formatting, extraction into a named method is probably not a good idea because the lambda is capturing `partitionId` from the enclosing scope.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services