You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ds...@apache.org on 2016/08/11 23:58:41 UTC

incubator-geode git commit: cleaned up comments

Repository: incubator-geode
Updated Branches:
  refs/heads/feature/GEODE-1714 29576f0f3 -> 7a6bd9c08


cleaned up comments


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/7a6bd9c0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/7a6bd9c0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/7a6bd9c0

Branch: refs/heads/feature/GEODE-1714
Commit: 7a6bd9c0862fdc24bbc11b958ba62032f5ef8c68
Parents: 29576f0
Author: Darrel Schneider <ds...@pivotal.io>
Authored: Thu Aug 11 16:06:42 2016 -0700
Committer: Darrel Schneider <ds...@pivotal.io>
Committed: Thu Aug 11 16:06:42 2016 -0700

----------------------------------------------------------------------
 .../com/gemstone/gemfire/internal/cache/AbstractRegionMap.java     | 2 --
 .../main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java   | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7a6bd9c0/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
index 299c09c..87620d8 100644
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
@@ -1610,7 +1610,6 @@ public abstract class AbstractRegionMap implements RegionMap {
         // generate versions and Tombstones for destroys
         boolean dispatchListenerEvent = inTokenMode;
         boolean opCompleted = false;
-        // TODO: passing DESTROYED to createEntry is ok as long as DiskEntry.Helper.initialize does not change the stats; keep in mind that newRe may not make it into the map
         // TODO: if inTokenMode then Token.DESTROYED is ok but what about !inTokenMode because owner.concurrencyChecksEnabled? In that case we do not want a DESTROYED token.
         RegionEntry newRe = getEntryFactory().createEntry(owner, key,
             Token.DESTROYED);
@@ -2017,7 +2016,6 @@ public abstract class AbstractRegionMap implements RegionMap {
             if (!ownerIsInitialized) {
               // when GII message arrived or processed later than invalidate
               // message, the entry should be created as placeholder
-              // TODO: passing INVALID as the value is ok as long as DiskEntry.Helper.initialize does not change the stats. Keep in mind that this entry may never make it into the region
               RegionEntry newRe = haveTombstone? tombstone : getEntryFactory().createEntry(owner, event.getKey(),
                   Token.INVALID);
               synchronized (newRe) {

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7a6bd9c0/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
index 703a677..144ffe4 100644
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
@@ -957,7 +957,7 @@ public interface DiskEntry extends RegionEntry {
           if (dr.isSync()) {
             if (AbstractRegionEntry.isCompressible(dr, newValue)) {
               //In case of compression the value is being set first
-              //so that writeToDisk and get it back from the entry
+              //so that writeToDisk can get it back from the entry
               //decompressed if it does not have it already in the event.
               // TODO: this may have introduced a bug with clear since
               //       writeToDisk can throw RegionClearedException which