You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/07/23 02:02:07 UTC

Review Request 36712: Added ONCE guard for Eventloop::initialize

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36712/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
-------

Added ONCE guard for Eventloop::initialize


Diffs
-----

  3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8 

Diff: https://reviews.apache.org/r/36712/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36712/#review92769
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On July 23, 2015, 12:17 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36712/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8 
> 
> Diff: https://reviews.apache.org/r/36712/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36712/#review93808
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Park


On July 23, 2015, 12:17 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36712/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8 
> 
> Diff: https://reviews.apache.org/r/36712/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36712/#review92701
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36712]

All tests passed.

- Mesos ReviewBot


On July 23, 2015, 12:17 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36712/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8 
> 
> Diff: https://reviews.apache.org/r/36712/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36712/
-----------------------------------------------------------

(Updated July 23, 2015, 12:17 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

added RB description


Repository: mesos


Description (updated)
-------

See summary.


Diffs
-----

  3rdparty/libprocess/src/libevent.cpp 02f9e61c1357e7b450e53b252b49d1979e782ae8 

Diff: https://reviews.apache.org/r/36712/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese