You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/20 18:11:57 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

lukecwik commented on a change in pull request #12637:
URL: https://github.com/apache/beam/pull/12637#discussion_r474178233



##########
File path: sdks/python/apache_beam/runners/worker/data_plane_test.py
##########
@@ -99,35 +100,33 @@ def send(instruction_id, transform_id, data):
 
     # Single write.
     send('0', transform_1, b'abc')
-    self.assertEqual(
+    hc.assert_that(

Review comment:
       I don't think this change updates the test to test the correct expectations since we should be testing that multiple messages are received in order over the channel.
   
   I believe `send` doesn't have the correct semantics since we want to have a persistent stream for the life of this test and to control when it gets closed after sending for a specific `instruction,transform` pair is done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org