[GitHub] [spark] huaxingao commented on a change in pull request #34799: [SPARK-37527][SQL] Translate more standard aggregate functions for pushdown

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #34799:
URL: https://github.com/apache/spark/pull/34799#discussion_r764178701



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -208,6 +208,9 @@ abstract class JdbcDialect extends Serializable with Logging{
       case max: Max =>
         if (max.column.fieldNames.length != 1) return None
         Some(s"MAX(${quoteIdentifier(max.column.fieldNames.head)})")
+      case avg: Average =>

Review comment:
       Is it right to push down `avg`? Should we use `sum` and `count` instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org