You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Can Celasun (JIRA)" <ji...@apache.org> on 2019/01/03 14:57:00 UTC

[jira] [Closed] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

     [ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Can Celasun closed THRIFT-3429.
-------------------------------
    Resolution: Information Provided

Since this issue is very old and the user can simply call Close() manually, I'm going to close this. If anyone thinks this needs further discussion, please reopen.

> Go THttpClient option to fully read/close HTTP response body after Flush
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-3429
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3429
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Library
>            Reporter: Justin Larrabee
>            Priority: Minor
>
> Currently the THttpTransport holds onto the HTTP response body until the owner calls Close(). When using keepalive this has the side effect of not releasing the TCP connection back to the HTTP client's pool until it is called. When creating many concurrent THttpTransport's this delay can cause a lot of additional connections to be created.
> I would suggest that the transport be configurable to fully read and close the HTTP response body after a Flush() call so that the connection is returned to the pool as quickly as possible.
> I would love some opinions on this suggestion. My patch for issue 3405 added a THttpClientOptions struct to make it easy to support additional features like this improvement without needing to alter the new public constructors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)