You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/06/01 21:23:27 UTC
[GitHub] [druid] gianm commented on a diff in pull request #12570: Service stdout log files, move logs to log/.
gianm commented on code in PR #12570:
URL: https://github.com/apache/druid/pull/12570#discussion_r887314259
##########
examples/bin/run-druid:
##########
@@ -42,7 +42,7 @@ if [ -z "$JAVA_BIN" ]; then
exit 1
fi
-LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/log}"
+LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/../log}"
Review Comment:
@FrankChen021 just wanted to double check with you to see if I am missing anything here. I think the `../` ends up doing more what you intended in https://github.com/apache/druid/pull/10147 anyway.
(Since `$WHEREAMI` is the `bin` directory, `$WHEREAMI/..` is the Druid distribution directory.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org