You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2026/09/10 12:58:50 UTC
[PR] [improve][client] Dispatch individual acknowledgments without capturing functions [pulsar]
lhotari opened a new pull request, #26525:
URL: https://github.com/apache/pulsar/pull/26525
### Motivation
Individual acknowledgment dispatch creates functions capturing properties and the tracker to select between grouped and immediate acknowledgment paths. Profiles observed allocation at these sites.
### Modifications
Replace private Function parameters with direct dispatch using properties and whether the caller already groups acknowledgments. Preserve list locking/final flush, interceptor ordering, property checks, batch and receipt behavior. Add an interceptor/property-order regression test and a real-tracker dispatch benchmark.
### Verifying this change
Historical integration profiling observed 2.6% lower consumer sampled allocation with flat CPU. JMH allocation was unchanged and did not establish a CPU improvement; the larger duplicate case had wide overlapping timing intervals. This is a targeted allocation cleanup, not a throughput claim; no new performance runs were made for extraction.
Local extraction validation passed: `spotlessCheck checkstyleMain checkstyleTest`, benchmark compilation, and 20 scoped tests with no failures or skips: org.apache.pulsar.client.impl.AcknowledgementsGroupingTrackerTest (17), org.apache.pulsar.client.api.InterceptorsTest (3). Retries were disabled; Gradle ran with `--max-workers=2 --no-parallel`.
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Dispatch individual acknowledgments without capturing functions [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #26525:
URL: https://github.com/apache/pulsar/pull/26525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org