[jira] [Commented] (CB-9990) Plugin build extras is no longer working in 5.4.0

["Joe Bowser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047787#comment-15047787 ] 

Joe Bowser commented on CB-9990:
--------------------------------

This may be related to the upgrade script.  Reinstalling the plugin should insert the gradle extension where it's supposed to be, however the upgrade shouldn't be killing the build.gradle file.

> Plugin build extras is no longer working in 5.4.0
> -------------------------------------------------
>
>                 Key: CB-9990
>                 URL: https://issues.apache.org/jira/browse/CB-9990
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.4.1
>         Environment: Mac (El Capitan)
>            Reporter: Ross Cullen
>            Assignee: Joe Bowser
>              Labels: Android
>             Fix For: 5.0.0
>
>
> Following the "Extending build.gradle" guide:
> https://cordova.apache.org/docs/en/edge/guide/platforms/android/tools.html
> We have been using the build-extras.gradle functionality in our custom plugin since 5.0.0 and it's been working great. With <framework src="some.gradle" custom="true" type="gradleReference" /> in the plugin.xml.
> It inserts the script into
> // PLUGIN GRADLE EXTENSIONS START
> apply from: "<plugin>/app-build-extras.gradle"
> // PLUGIN GRADLE EXTENSIONS END
> Upgrading to 5.4.0 and this functionality seems to be gone.
> i.e. the above line is blank after a rebuild
> // PLUGIN GRADLE EXTENSIONS START
> // PLUGIN GRADLE EXTENSIONS END



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org