[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #4352: [HUDI-1295] Metadata Index - Bloom filter and Column stats index to speed up index lookups

[GitBox <gi...@apache.org>]

xiarixiaoyao commented on a change in pull request #4352:
URL: https://github.com/apache/hudi/pull/4352#discussion_r774457700



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java
##########
@@ -380,4 +382,76 @@ public Boolean apply(String recordKey) {
 
     return val;
   }
+
+  /**
+   * Parse min/max statistics stored in parquet footers for all columns.
+   */
+  public Collection<HoodieColumnStatsMetadata<Comparable>> readColumnStatsFromParquetMetadata(Configuration conf,
+                                                                                              String partitionPath,

Review comment:
       we already has a function readRangeFromParquetMetadata to read min-max and null count info ,  could you reuse that function.    readRangeFromParquetMetadata  solve the problem of reading datetype type statistics concurrently




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org