You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/11 16:13:12 UTC
[jira] [Commented] (FLINK-3836) Change Histogram to enable Long
counters
[ https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280349#comment-15280349 ]
ASF GitHub Bot commented on FLINK-3836:
---------------------------------------
GitHub user mbode reopened a pull request:
https://github.com/apache/flink/pull/1966
[FLINK-3836] Add LongHistogram accumulator
New accumulator `LongHistogram`; the `Histogram` accumulator now throws an `IllegalArgumentException` instead of letting the int overflow.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbode/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1966.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1966
----
commit f457319481701a1234c9ea7d29da24f857ae4241
Author: Maximilian Bode <ma...@tngtech.com>
Date: 2016-04-27T15:19:16Z
[Flink-3836] Add LongHistogram accumulator
----
> Change Histogram to enable Long counters
> ----------------------------------------
>
> Key: FLINK-3836
> URL: https://issues.apache.org/jira/browse/FLINK-3836
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.2
> Reporter: Maximilian Bode
> Assignee: Maximilian Bode
> Priority: Minor
>
> Change flink/flink-core/src/main/java/org/apache/flink/api/common/accumulators/Histogram.java to enable Long counts instead of Integer. In particular, change the TreeMap to be <Integer, Long>.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)