You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <br...@users.sf.net> on 2014/07/23 17:43:38 UTC

[allura:tickets] #7585 Require password entry for changes to email settings



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** open
**Milestone:** forge-aug-8
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Wed Jul 23, 2014 03:43 PM UTC
**Owner:** nobody

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Dave Brondsema <br...@users.sf.net>.
- **Size**:  --> 1



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** in-progress
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Fri Aug 22, 2014 04:33 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Igor Bondarenko <je...@users.sf.net>.
- **status**: in-progress --> code-review
- **Comment**:

It was pretty silly mistake, which I somehow missed. Html for the password popup was in **the only** block, which was overridden by sf :)

Updated `je/42cc_7585`



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** code-review
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Tue Aug 26, 2014 08:01 AM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Igor Bondarenko <je...@users.sf.net>.
- **status**: in-progress --> code-review
- **Comment**:

Closed #624. `je/42cc_7585`



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** code-review
**Milestone:** forge-aug-8
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Fri Jul 25, 2014 04:50 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> closed



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** closed
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Tue Aug 26, 2014 02:53 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Dave Brondsema <br...@users.sf.net>.
- **Milestone**: forge-aug-8 --> forge-sep-5



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** in-progress
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Mon Aug 18, 2014 09:24 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Dave Brondsema <br...@users.sf.net>.
- **labels**:  --> 42cc
- **status**: open --> in-progress
- **assigned_to**: Igor Bondarenko



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** in-progress
**Milestone:** forge-aug-8
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Wed Jul 23, 2014 03:43 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Igor Bondarenko <je...@users.sf.net>.
- **status**: in-progress --> code-review
- **Comment**:

Closed #639. Force-pushed `je/42cc_7585`



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** code-review
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Fri Aug 22, 2014 05:14 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Dave Brondsema <br...@users.sf.net>.
Seems like I am missing something.  The Delete, Claim New Address, and Save buttons don't do anything now.  I don't see any errors in the console either.  Tried Firefox and Chrome.  Am I missing something?


---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** code-review
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Mon Aug 25, 2014 11:34 AM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> in-progress
- **QA**: Dave Brondsema
- **Comment**:

This works perfectly fine, but the UI is confusing I think.  We made some good improvements to the UI of this form a little while ago, so I'd like to continue making it better and not regress at all.  Its confusing because the claim & delete buttons are above the password field, so its not obvious you need to enter your password to use those buttons.

One idea would be to have the password hidden from the form until you submit it (delete, claim, or save button) and then pop up a dialog asking for password to confirm the action.  I don't know how tricky the JS would have to be to do that though.

Another theoretical idea would be to put the password field in a place that is clearly required for all the submit buttons.  All I can think of is putting it at the top of the form, but that might look odd too.  Perhaps it would be good enough if it also has the `required` attribute so that the browser tells you right away if you missed it, instead of waiting for the page submission. (That might even be good enough keeping the field at the bottom of the form too).  Would the `required` attribute work with the multiple submit buttons though?  Maybe need a bit of JS to enforce the password field is filled out.  Probably easier than the dialog idea above.



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** in-progress
**Milestone:** forge-aug-8
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Thu Jul 31, 2014 02:47 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7585 Require password entry for changes to email settings

Posted by Igor Bondarenko <je...@users.sf.net>.
- **status**: code-review --> in-progress
- **Comment**:

Sorry, forgot to test on a sandbox. Don't sure why it's not working. I see new js is there but still no reaction. Created ticket to investigate.



---

** [tickets:#7585] Require password entry for changes to email settings**

**Status:** in-progress
**Milestone:** forge-sep-5
**Labels:** 42cc 
**Created:** Wed Jul 23, 2014 03:43 PM UTC by Dave Brondsema
**Last Updated:** Mon Aug 25, 2014 05:00 PM UTC
**Owner:** Igor Bondarenko

Adding an email address, removing an email address or changing your primary address are important account operations and it would be good to require entering your password again to make those changes.  This will help avoid the possibility of someone gaining permanent access to an account that was left open, for example.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.