You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/08 05:45:59 UTC

[GitHub] [superset] pkdotson opened a new pull request #14013: chore(toggle thumbnails): use localstorage for toggle

pkdotson opened a new pull request #14013:
URL: https://github.com/apache/superset/pull/14013


   ### SUMMARY
   This is follow up for toggle thumbnails for homescreen to make the listviews show thumbnails based off homescreen toggle.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   https://user-images.githubusercontent.com/17326228/113974491-e1235100-97f2-11eb-9524-808d7f44b4d4.mov
   
   ### TEST PLAN
   enable feature flag THUMBNAILS = True
   check each listview for toggle of thumbnails
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (23dd545) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **decrease** coverage by `0.88%`.
   > The diff coverage is `60.00%`.
   
   > :exclamation: Current head 23dd545 differs from pull request most recent head adb0018. Consider uploading reports for the commit adb0018 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   - Coverage   79.28%   78.40%   -0.89%     
   ==========================================
     Files         936      936              
     Lines       47408    47571     +163     
     Branches     5938     5997      +59     
   ==========================================
   - Hits        37589    37299     -290     
   - Misses       9693    10132     +439     
   - Partials      126      140      +14     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `49.28% <0.00%> (-6.77%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `48.27% <0.00%> (-31.22%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `52.11% <ø> (-24.98%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `45.16% <ø> (-18.48%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `81.05% <ø> (-3.57%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `53.70% <50.00%> (-28.35%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `73.40% <50.00%> (-7.13%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `72.09% <100.00%> (-12.41%)` | :arrow_down: |
   | [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
   | [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
   | ... and [48 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...adb0018](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819249670


   > When thumbnail IS enabled, the default is still card view, can we make it consistent, default to list for all time? @pkdotson
   
   My understanding is that the selection of list/cards should be set via `LISTVIEWS_DEFAULT_CARD_VIEW` and decoupled from the thumbnail feature flag (`THUMBNAILS`).
   
   > please note: currently view is not sticky. after user switch from list to card view, and refresh, it lands on list view again. that should be the expected behavior as well.
   
   As I understand from the title, the "stickiness" is the point of this PR... the description could probably be clearer on this the intent, and the testing steps). If the view setting is not being saved/retrieved here, then something may be wrong.
   
   From the video, it looks like thumbnail display IS sticking. I'll do a test as well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (824361f) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **decrease** coverage by `1.64%`.
   > The diff coverage is `78.57%`.
   
   > :exclamation: Current head 824361f differs from pull request most recent head 0ba4b1b. Consider uploading reports for the commit 0ba4b1b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   - Coverage   79.28%   77.64%   -1.65%     
   ==========================================
     Files         936      936              
     Lines       47408    47571     +163     
     Branches     5938     6001      +63     
   ==========================================
   - Hits        37589    36937     -652     
   - Misses       9693    10477     +784     
   - Partials      126      157      +31     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `44.19% <45.45%> (-11.85%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.33% <ø> (-6.20%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `52.11% <ø> (-24.98%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `45.16% <ø> (-18.48%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `81.05% <0.00%> (-3.57%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `51.78% <75.00%> (-30.27%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `78.10% <80.00%> (-6.39%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `67.79% <100.00%> (-11.70%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
   | ... and [98 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...0ba4b1b](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] henryyeh commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
henryyeh commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-823480019


   label:2021.13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (713a673) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **increase** coverage by `0.12%`.
   > The diff coverage is `94.82%`.
   
   > :exclamation: Current head 713a673 differs from pull request most recent head 1589d95. Consider uploading reports for the commit 1589d95 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   + Coverage   79.28%   79.41%   +0.12%     
   ==========================================
     Files         936      936              
     Lines       47408    47444      +36     
     Branches     5938     5954      +16     
   ==========================================
   + Hits        37589    37677      +88     
   + Misses       9693     9639      -54     
   - Partials      126      128       +2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <66.66%> (+0.01%)` | :arrow_up: |
   | javascript | `68.87% <93.93%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `77.08% <ø> (ø)` | |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `63.63% <ø> (ø)` | |
   | [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `84.32% <80.00%> (-0.17%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `80.50% <80.00%> (-0.03%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `80.48% <100.00%> (+1.00%)` | :arrow_up: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `83.33% <100.00%> (+1.28%)` | :arrow_up: |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `73.72% <100.00%> (+2.17%)` | :arrow_up: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `84.61% <100.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...1589d95](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] henryyeh commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
henryyeh commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-823480555


   :label:2021.13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (713a673) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **decrease** coverage by `0.00%`.
   > The diff coverage is `87.27%`.
   
   > :exclamation: Current head 713a673 differs from pull request most recent head 1589d95. Consider uploading reports for the commit 1589d95 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   - Coverage   79.28%   79.28%   -0.01%     
   ==========================================
     Files         936      936              
     Lines       47408    47653     +245     
     Branches     5938     6019      +81     
   ==========================================
   + Hits        37589    37780     +191     
   - Misses       9693     9747      +54     
     Partials      126      126              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <66.66%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `52.11% <ø> (-24.98%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `45.16% <ø> (-18.48%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `81.05% <0.00%> (-3.57%)` | :arrow_down: |
   | [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <66.66%> (-0.41%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `73.21% <75.00%> (-8.84%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `77.27% <75.00%> (-3.26%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `81.09% <80.00%> (-3.41%)` | :arrow_down: |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `72.88% <100.00%> (-6.61%)` | :arrow_down: |
   | ... and [19 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...1589d95](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819250806


   /testenv up FEATURE_THUMBNAILS=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (23dd545) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **decrease** coverage by `0.51%`.
   > The diff coverage is `46.15%`.
   
   > :exclamation: Current head 23dd545 differs from pull request most recent head 0ba4b1b. Consider uploading reports for the commit 0ba4b1b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   - Coverage   79.28%   78.77%   -0.52%     
   ==========================================
     Files         936      936              
     Lines       47408    47656     +248     
     Branches     5938     6026      +88     
   ==========================================
   - Hits        37589    37542      -47     
   - Misses       9693     9982     +289     
   - Partials      126      132       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.32% <0.00%> (-2.73%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `48.27% <0.00%> (-31.22%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `52.11% <ø> (-24.98%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `45.16% <ø> (-18.48%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `81.05% <ø> (-3.57%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `80.37% <50.00%> (-4.13%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `53.70% <50.00%> (-28.35%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `73.40% <50.00%> (-7.13%)` | :arrow_down: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
   | ... and [25 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...0ba4b1b](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819249670


   > When thumbnail IS enabled, the default is still card view, can we make it consistent, default to list for all time? @pkdotson
   
   My understanding is that the selection of list/cards should be set via `LISTVIEWS_DEFAULT_CARD_VIEW` and decoupled from the thumbnail feature flag (`THUMBNAILS`).
   
   > please note: currently view is not sticky. after user switch from list to card view, and refresh, it lands on list view again. that should be the expected behavior as well.
   
   As I understand from the title, the "stickiness" is the point of this PR... the description could probably be clearer on this the intent, and the testing steps). If the view setting is not being saved/retrieved here, then something may be wrong.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] henryyeh removed a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
henryyeh removed a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-823480019


   label:2021.13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (824361f) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **decrease** coverage by `1.64%`.
   > The diff coverage is `78.57%`.
   
   > :exclamation: Current head 824361f differs from pull request most recent head 1589d95. Consider uploading reports for the commit 1589d95 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   - Coverage   79.28%   77.64%   -1.65%     
   ==========================================
     Files         936      936              
     Lines       47408    47571     +163     
     Branches     5938     6001      +63     
   ==========================================
   - Hits        37589    36937     -652     
   - Misses       9693    10477     +784     
   - Partials      126      157      +31     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `44.19% <45.45%> (-11.85%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `74.33% <ø> (-6.20%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `52.11% <ø> (-24.98%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `45.16% <ø> (-18.48%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `81.05% <0.00%> (-3.57%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `51.78% <75.00%> (-30.27%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `78.10% <80.00%> (-6.39%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `67.79% <100.00%> (-11.70%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
   | ... and [98 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...1589d95](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819258688


   @rusackas Ephemeral environment spinning up at http://34.215.48.184:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] henryyeh commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
henryyeh commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-823480805


   :label:2021.13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819252317


   @rusackas Ephemeral environment spinning up at http://52.12.121.187:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819256380


   /testenv down


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #14013:
URL: https://github.com/apache/superset/pull/14013


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-819256583


   /testenv up FEATURE_THUMBNAILS=True


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-815473845


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=h1) Report
   > Merging [#14013](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=desc) (23dd545) into [master](https://codecov.io/gh/apache/superset/commit/b5c95c537c6cefb3e36eac8b82625565a5152a8a?el=desc) (b5c95c5) will **decrease** coverage by `0.51%`.
   > The diff coverage is `46.15%`.
   
   > :exclamation: Current head 23dd545 differs from pull request most recent head adb0018. Consider uploading reports for the commit adb0018 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   - Coverage   79.28%   78.77%   -0.52%     
   ==========================================
     Files         936      936              
     Lines       47408    47656     +248     
     Branches     5938     6026      +88     
   ==========================================
   - Hits        37589    37542      -47     
   - Misses       9693     9982     +289     
   - Partials      126      132       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.32% <0.00%> (-2.73%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `48.27% <0.00%> (-31.22%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `52.11% <ø> (-24.98%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `45.16% <ø> (-18.48%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `81.05% <ø> (-3.57%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `80.37% <50.00%> (-4.13%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `53.70% <50.00%> (-28.35%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `73.40% <50.00%> (-7.13%)` | :arrow_down: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
   | ... and [25 more](https://codecov.io/gh/apache/superset/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=footer). Last update [b5c95c5...adb0018](https://codecov.io/gh/apache/superset/pull/14013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14013: chore(toggle thumbnails): use localstorage for toggle

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14013:
URL: https://github.com/apache/superset/pull/14013#issuecomment-820907776


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org