[GitHub] storm issue #1487: off-by-one error for UNCOMMITTED_LATEST and UNCOMMITTED_E...

[srdo <gi...@git.apache.org>]

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/1487
  
    Are you sure this is the case? It looks to me like the spout is committing the offset of the latest acked tuple that doesn't have uncommitted predecessors. It seems to make sense that it seeks to the last committed offset +1, since that's the earliest unacked message.
    
    The API does suggest doing the +1 on commit instead, but I'd imagine that's just a matter of taste.
    
    "The committed offset should be the next message your application will consume, i.e. lastProcessedMessageOffset + 1." (see https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html under commitSync(Map))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---