You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AlbumenJ (via GitHub)" <gi...@apache.org> on 2023/05/18 08:52:48 UTC

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12294: Add log for remote configuration.

AlbumenJ commented on code in PR #12294:
URL: https://github.com/apache/dubbo/pull/12294#discussion_r1197572027


##########
dubbo-common/src/main/java/org/apache/dubbo/common/config/ConfigurationUtils.java:
##########
@@ -173,25 +172,23 @@ public static int get(ScopeModel scopeModel, String property, int defaultValue)
 
     public static Map<String, String> parseProperties(String content) throws IOException {
         Map<String, String> map = new HashMap<>();
-        if (StringUtils.isEmpty(content)) {
-            logger.warn(COMMON_UNEXPECTED_EXCEPTION, "", "", "Config center was specified, but no config item found.");

Review Comment:
   Why change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org