[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2703: ARTEMIS-2380 Fix delivering message in the case of consume close
URL: https://github.com/apache/activemq-artemis/pull/2703#discussion_r310341667
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -1175,6 +1179,17 @@ public void addConsumer(final Consumer consumer) throws Exception {
 
    }
 
+   @Override
+   public void addLingerRef(Consumer consumer, MessageReference lingerRef) throws Exception {
+      lingerRef.emptyConsumerID();
+      lingerRefMap.put(lingerRef, consumer);
 
 Review comment:
   On that note, need to ensure order is preserved hashmap looses any ordering

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services