You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/02/15 13:19:55 UTC

[GitHub] flink pull request #3321: [FLINK-5773] Use akka.actor.Status.Failure class t...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3321

    [FLINK-5773] Use akka.actor.Status.Failure class to send failures via AskSupport

    Akka's AskSupport trait requires that failures are wrapped in a akka.actor.Status.Failure
    to be recognized. Internally the trait will unwrap the failure and wrap it in a
    scala.util.Failure instance. However, it does not recognize the scala Failure when given
    to the AskSupport trait. As a consequence it would wrap scala.util.Failure in a
    scala.util.Success instance.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink FLINK-5773

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3321
    
----
commit e7e0431503f53fe9b8f36971a18d07ab0d16faf4
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-02-15T13:16:26Z

    [FLINK-5773] Use akka.actor.Status.Failure class to send failures via AskSupport
    
    Akka's AskSupport trait requires that failures are wrapped in a akka.actor.Status.Failure
    to be recognized. Internally the trait will unwrap the failure and wrap it in a
    scala.util.Failure instance. However, it does not recognize the scala Failure when given
    to the AskSupport trait. As a consequence it would wrap scala.util.Failure in a
    scala.util.Success instance.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3321: [FLINK-5773] Use akka.actor.Status.Failure class to send ...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3321
  
    Good fix, +1 to merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3321: [FLINK-5773] Use akka.actor.Status.Failure class t...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3321


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3321: [FLINK-5773] Use akka.actor.Status.Failure class to send ...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3321
  
    Thanks for the review @StephanEwen. Tests have passed on Travis. Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---