[superset] branch master updated: feat(embedded-SDK): enable CSV download (#20416)

[li...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lilykuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 655646d35b feat(embedded-SDK): enable CSV download (#20416)
655646d35b is described below

commit 655646d35bea8f52d805d1bcc36e58d10fb8a6d5
Author: Lily Kuang <li...@preset.io>
AuthorDate: Wed Aug 3 10:59:18 2022 -0700

    feat(embedded-SDK): enable CSV download (#20416)
    
    * feat(embedded-sdk): enable CSV download
    
    * lint
---
 superset-embedded-sdk/src/index.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-embedded-sdk/src/index.ts b/superset-embedded-sdk/src/index.ts
index 32b02641e0..317195522c 100644
--- a/superset-embedded-sdk/src/index.ts
+++ b/superset-embedded-sdk/src/index.ts
@@ -105,9 +105,10 @@ export async function embedDashboard({
       iframe.sandbox.add("allow-scripts"); // obviously the iframe needs scripts
       iframe.sandbox.add("allow-presentation"); // for fullscreen charts
       iframe.sandbox.add("allow-downloads"); // for downloading charts as image
+      iframe.sandbox.add("allow-forms"); // for forms to submit
+      iframe.sandbox.add("allow-popups"); // for exporting charts as csv
       // add these ones if it turns out we need them:
       // iframe.sandbox.add("allow-top-navigation");
-      // iframe.sandbox.add("allow-forms");
 
       // add the event listener before setting src, to be 100% sure that we capture the load event
       iframe.addEventListener('load', () => {