[GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...

[jeking3 <gi...@git.apache.org>]

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1080#discussion_r97708735
  
    --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
    @@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
       }
     
       // sets a flag so that the loop exits on the next event
    -  event_base_loopbreak(eventBase_);
    +  event_base_loopexit(eventBase_, 0);
    --- End diff --
    
    I am curious to understand why this was changed.  event_base_loopexit will cause the lop to continue processing until drained.  This function is called breakLoop and I assume that means stop as soon as possible, which is what it was doing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---