[jira] [Commented] (STORM-506) UI Counts acks & fails from bolts in "Topology Stats"

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153989#comment-14153989 ] 

ASF GitHub Bot commented on STORM-506:
--------------------------------------

Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/267#issuecomment-57397765
  
    @d2r @revans2  I ran a test with this PR the topology stats missing complete latency and ack, fail numbers and also spout. Here is the screen shot http://grab.by/APka.
    I remember trying todo something similar for UI api. I think summing (merge-with) of acks and fails expects all these keys to be present from both the agg-bolt-stats an agg-spout-stats otherwise it won't take in :acked, :failed, :complete-latencies form agg-spout-stats.  


> UI Counts acks & fails from bolts in "Topology Stats"
> -----------------------------------------------------
>
>                 Key: STORM-506
>                 URL: https://issues.apache.org/jira/browse/STORM-506
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Derek Dagit
>            Assignee: Derek Dagit
>
> The aggregation for the total topology statistics should count acks and fails for tuple "trees" only, but it includes acks and fails of bolts as well.
> [code|https://github.com/apache/storm/blob/cfcedcf4ad5e5c96fe3f30a0b710cfc604063231/storm-core/src/clj/backtype/storm/ui/core.clj#L344]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)