[jira] [Commented] (BEAM-1684) Add unit tests for iobase.py

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951980#comment-15951980 ] 

ASF GitHub Bot commented on BEAM-1684:
--------------------------------------

GitHub user duraza opened a pull request:

    https://github.com/apache/beam/pull/2397

    [BEAM-1684] Add unit tests for iobase.py.

    **Summary**: This pull request adds unit tests for Dataflow's `iobase.py`
    **Comments**: As this is my first PR to Beam, I erred on the side of caution, adding a large number of tests. The file I am testing is largely a base class with limited functionality, so these tests are very likely to be redundant, and debatably unnecessary. Please let me know, and I'll be sure to correct accordingly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duraza/beam add-dataflow-iobase-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2397
    
----
commit 96f77cd61cb6f9b001e5f53d15c9ef2418111b48
Author: Rahul Sabbineni <du...@users.noreply.github.com>
Date:   2017-04-01T03:35:21Z

    [BEAM-1684] Add unit tests for iobase.py.

----


> Add unit tests for iobase.py
> ----------------------------
>
>                 Key: BEAM-1684
>                 URL: https://issues.apache.org/jira/browse/BEAM-1684
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py
>            Reporter: Tibor Kiss
>            Assignee: Rahul Sabbineni
>            Priority: Minor
>
> Python-SDK's {{apache_beam/runners/dataflow/native_io/iobase.py}} does not have associated unit tests and has low (indirect) test coverage.
>  
> Create the respective tests to ensure code quality and increase test coverage.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)