You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/12/20 21:01:33 UTC

[GitHub] ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes

ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes
URL: https://github.com/apache/bookkeeper/pull/898#discussion_r158134591
 
 

 ##########
 File path: bookkeeper-proto/src/main/proto/BookkeeperProtocol.proto
 ##########
 @@ -90,6 +90,7 @@ message ReadRequest {
     enum Flag {
         FENCE_LEDGER = 1;
         ENTRY_PIGGYBACK = 2;
+        RECOVERY_READ = 3;
 
 Review comment:
   @merlimat @sijie 
   There's a potential thorny BC issue here. On yahoo branch, RECOVERY_READ is 2.https://github.com/yahoo/bookkeeper/blob/165971209f933e0bcefaac997db8e75c8776f942/bookkeeper-server/src/main/proto/BookkeeperProtocol.proto#L83
   
   @merlimat are any any the yahoo clients using protobufs? Or are they all on V2? If so it may not be a problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services