You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/12/23 06:27:12 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2836: FINERACT-1837: DelinquencyBucketsIntegrationTest performance
josehernandezfintecheandomx opened a new pull request, #2836:
URL: https://github.com/apache/fineract/pull/2836
## Description
DelinquencyBucketsIntegrationTest.testLoanClassificationStepAsPartOfCOB test is running for 10 mins.
This test need to be refactored to decrease the execution time drastically.
[FINERACT-1837](https://issues.apache.org/jira/browse/FINERACT-1837)
<img width="1484" alt="Screenshot 2022-12-23 at 0 17 02" src="https://user-images.githubusercontent.com/44206706/209283514-13501c35-5aa3-49de-8c37-2a56086acc22.png">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2836: FINERACT-1837: DelinquencyBucketsIntegrationTest performance
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2836:
URL: https://github.com/apache/fineract/pull/2836#issuecomment-1363942237
@josehernandezfintecheandomx can you please add a screenshot about the time it took originally for the test to run and after your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2836: FINERACT-1837: DelinquencyBucketsIntegrationTest performance
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #2836:
URL: https://github.com/apache/fineract/pull/2836#issuecomment-1366121869
> @josehernandezfintecheandomx can you please add a screenshot about the time it took originally for the test to run and after your changes?
@galovics Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2836: FINERACT-1837: DelinquencyBucketsIntegrationTest performance
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2836:
URL: https://github.com/apache/fineract/pull/2836#issuecomment-1366601186
@josehernandezfintecheandomx can you do a rebase on this PR please? The PostgreSQL tests are failing for the 4th time, maybe a rebase will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2836: FINERACT-1837: DelinquencyBucketsIntegrationTest performance
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2836:
URL: https://github.com/apache/fineract/pull/2836#issuecomment-1366601274
@josehernandezfintecheandomx can you do a rebase on this PR please? The PostgreSQL tests are failing for the 4th time, maybe a rebase will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2836: FINERACT-1837: DelinquencyBucketsIntegrationTest performance
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2836:
URL: https://github.com/apache/fineract/pull/2836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org