You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/03 03:57:39 UTC
[GitHub] [spark] yaooqinn opened a new pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
yaooqinn opened a new pull request #28713:
URL: https://github.com/apache/spark/pull/28713
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
This PR set the hour to 12/0 when the AMPM_OF_DAY field exists
### Why are the changes needed?
When the hour is absent but the am-pm is present, the time is incorrect for pm
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638001145
**[Test build #123460 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123460/testReport)** for PR 28713 at commit [`81eb751`](https://github.com/apache/spark/commit/81eb75180be7b4ae36a33a5b9594be78c2705c5a).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638188406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638268919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638197978
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638001444
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638097594
**[Test build #123481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123481/testReport)** for PR 28713 at commit [`6353ed7`](https://github.com/apache/spark/commit/6353ed76cf822f40aebcf5742b01012c4220c975).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638267160
**[Test build #123481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123481/testReport)** for PR 28713 at commit [`6353ed7`](https://github.com/apache/spark/commit/6353ed76cf822f40aebcf5742b01012c4220c975).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637939101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637938747
**[Test build #123460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123460/testReport)** for PR 28713 at commit [`81eb751`](https://github.com/apache/spark/commit/81eb75180be7b4ae36a33a5b9594be78c2705c5a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638188406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638001444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638091417
**[Test build #123465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123465/testReport)** for PR 28713 at commit [`c0ede09`](https://github.com/apache/spark/commit/c0ede09e4bbd3a1f4b85c984e18a61e0b1bb7ef5).
* This patch **fails Spark unit tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638097594
**[Test build #123481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123481/testReport)** for PR 28713 at commit [`6353ed7`](https://github.com/apache/spark/commit/6353ed76cf822f40aebcf5742b01012c4220c975).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638013611
**[Test build #123468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123468/testReport)** for PR 28713 at commit [`6353ed7`](https://github.com/apache/spark/commit/6353ed76cf822f40aebcf5742b01012c4220c975).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638006269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638097083
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638186958
**[Test build #123467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123467/testReport)** for PR 28713 at commit [`6b35051`](https://github.com/apache/spark/commit/6b35051480cab076a0b85eacc0930f9c096ed518).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638009567
**[Test build #123467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123467/testReport)** for PR 28713 at commit [`6b35051`](https://github.com/apache/spark/commit/6b35051480cab076a0b85eacc0930f9c096ed518).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638006269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638014226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638091912
Build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638105464
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637999151
**[Test build #123465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123465/testReport)** for PR 28713 at commit [`c0ede09`](https://github.com/apache/spark/commit/c0ede09e4bbd3a1f4b85c984e18a61e0b1bb7ef5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638192002
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637999542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638105249
**[Test build #123468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123468/testReport)** for PR 28713 at commit [`6353ed7`](https://github.com/apache/spark/commit/6353ed76cf822f40aebcf5742b01012c4220c975).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638010259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638098118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28713:
URL: https://github.com/apache/spark/pull/28713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637977012
cc @cloud-fan @maropu @MaxGekk thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637939101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638091920
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123465/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638091912
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638268919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638009567
**[Test build #123467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123467/testReport)** for PR 28713 at commit [`6b35051`](https://github.com/apache/spark/commit/6b35051480cab076a0b85eacc0930f9c096ed518).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638105464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
cloud-fan removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638192002
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638010259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638014226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28713:
URL: https://github.com/apache/spark/pull/28713#discussion_r434352851
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -62,7 +62,16 @@ trait DateTimeFormatterHelper {
accessor.get(ChronoField.HOUR_OF_DAY)
} else if (accessor.isSupported(ChronoField.HOUR_OF_AMPM)) {
// When we reach here, it means am/pm is not specified. Here we assume it's am.
+ // All of CLOCK_HOUR_OF_AMPM(h)/HOUR_OF_DAY(H)/CLOCK_HOUR_OF_DAY(k)/HOUR_OF_AMPM(K) will
+ // be resolved to HOUR_OF_AMPM here, we do not need to handle them separately
accessor.get(ChronoField.HOUR_OF_AMPM)
+ } else if (accessor.isSupported(ChronoField.AMPM_OF_DAY) &&
+ accessor.get(ChronoField.AMPM_OF_DAY) == 1) {
+ // When reach here, the `hour` part is missing, the pattern is always contains `a` and minute
Review comment:
the `hour` part is missing and PM is specified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638105470
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123468/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638001452
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123460/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637999542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-638098118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637999151
**[Test build #123465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123465/testReport)** for PR 28713 at commit [`c0ede09`](https://github.com/apache/spark/commit/c0ede09e4bbd3a1f4b85c984e18a61e0b1bb7ef5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28713: [SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28713:
URL: https://github.com/apache/spark/pull/28713#issuecomment-637938747
**[Test build #123460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123460/testReport)** for PR 28713 at commit [`81eb751`](https://github.com/apache/spark/commit/81eb75180be7b4ae36a33a5b9594be78c2705c5a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org