[GitHub] [carbondata] kevinjmh edited a comment on issue #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

[GitBox <gi...@apache.org>]

kevinjmh edited a comment on issue #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection
URL: https://github.com/apache/carbondata/pull/3101#issuecomment-490706725
 
 
   > @qiuchenjian I feel the old fix of restricting all `group by columns must be present in projection ` was alright. It is better user knows the restriction instead of we adding those group by columns to the projections automatically while creating MV. It will add more complexity to the code if we are trying to add things automatically.
   
   +1
   Since looking up data in MV for groudby-ed data, the grouping columns is a must. That restriction can remind the user know the schema of datamap too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services