You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/01 23:27:55 UTC
[GitHub] [cloudstack] nvuillam opened a new pull request #6194: Use MegaLinter for better performances
nvuillam opened a new pull request #6194:
URL: https://github.com/apache/cloudstack/pull/6194
### Description
A simple test to compare performances between SuperLinter and [MegaLinter,](https://megalinter.github.io/latest/) with the same scope
SuperLinter: 12mn -> https://github.com/apache/cloudstack/runs/5793039795?check_suite_focus=true
MegaLinter: 2mn -> https://github.com/nvuillam/cloudstack/runs/5795833342?check_suite_focus=true
As this PR was unsollicited, please feel free to refuse it, no problem :)
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6194: Use MegaLinter for better performances
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6194:
URL: https://github.com/apache/cloudstack/pull/6194#issuecomment-1086509443
Thanks for the PR @nvuillam - @jbampton can I please get your feedback/review on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #6194: Use MegaLinter for better performances
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #6194:
URL: https://github.com/apache/cloudstack/pull/6194#issuecomment-1086642778
Seems `GitHub` make the Super-Linter so from the Apache Infra page it is allowed. I am not sure whether the Mega-Linter is allowed. Anyway from what I have heard the Mega-Linter is faster.
From the `infra` page:
"Notice: December 27, 2020: We only allow Actions that are official "Made by GitHub" or local to the Apache org on GitHub, to address a potential security vulnerability. This is an incident-related policy change. We are researching the situation, and the policy may evolve based on what we learn."
https://infra.apache.org/github-actions-secrets.html
https://github.com/github/super-linter
https://github.com/megalinter/megalinter
https://github.com/marketplace/actions/super-linter
https://github.com/marketplace/actions/megalinter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org