[GitHub] [daffodil] tuxji commented on a diff in pull request #830: Add dependency scanning for the build.sbt

[GitBox <gi...@apache.org>]

tuxji commented on code in PR #830:
URL: https://github.com/apache/daffodil/pull/830#discussion_r949099125


##########
.github/workflows/dependency-scan.yml:
##########
@@ -0,0 +1,27 @@
+name: Dependency scan

Review Comment:
   This file fails our Rat audit check.  Please prepend the Apache license before the name:
   
   ```
   # Licensed to the Apache Software Foundation (ASF) under one or more
   # contributor license agreements. See the NOTICE file distributed with
   # this work for additional information regarding copyright ownership.
   # The ASF licenses this file to You under the Apache License, Version 2.0
   # (the "License"); you may not use this file except in compliance with
   # the License. You may obtain a copy of the License at
   #
   # http://www.apache.org/licenses/LICENSE-2.0
   #
   # Unless required by applicable law or agreed to in writing, software
   # distributed under the License is distributed on an "AS IS" BASIS,
   # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   # See the License for the specific language governing permissions and
   # limitations under the License.
   
   name: Dependency Scan
   ```



##########
.github/workflows/dependency-scan.yml:
##########
@@ -0,0 +1,27 @@
+name: Dependency scan
+
+# Controls when the workflow will run
+on:
+  # Triggers the workflow on push or pull request events but only for the "main" branch
+  push:
+    branches: [ "main" ]
+    
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  # This workflow contains a single job called "build"
+  build:
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest
+
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - uses: actions/checkout@v3

Review Comment:
   We pin our workflows to actions/checkout@v3.0.2 instead of actions/checkout@v3 in order to perform due diligence on every version update.  Besides safeguarding our build security, this lets us become aware of any changes to github actions such as new API that could be useful to us.  Dependabot bumps the version for us so we won't miss updates.



##########
.github/workflows/dependency-scan.yml:
##########
@@ -0,0 +1,27 @@
+name: Dependency scan
+
+# Controls when the workflow will run
+on:
+  # Triggers the workflow on push or pull request events but only for the "main" branch
+  push:
+    branches: [ "main" ]
+    
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  # This workflow contains a single job called "build"
+  build:
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest

Review Comment:
   We pin our workflows to ubuntu-20.04 rather than ubuntu-latest in order to perform due diligence on every version update.  GitHub sends announcements when changing ubuntu-latest to the next version so we won't miss the bump, although we may switch to ubuntu-22.04 sooner without waiting for GitHub.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org