You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/07/14 21:23:42 UTC

[GitHub] [trafficserver] zwoop commented on a diff in pull request #10002: Use cmake-format for consistent CMakeLists.txt formatting

zwoop commented on code in PR #10002:
URL: https://github.com/apache/trafficserver/pull/10002#discussion_r1264186546


##########
iocore/dns/CMakeLists.txt:
##########
@@ -15,24 +15,19 @@
 #
 #######################
 
-
-add_library(inkdns STATIC
-    DNS.cc
-    DNSConnection.cc
-    Inline.cc
-    SplitDNS.cc
+add_library(inkdns STATIC DNS.cc DNSConnection.cc Inline.cc SplitDNS.cc)
+target_include_directories(
+    inkdns
+    PRIVATE ${CMAKE_SOURCE_DIR}/iocore/eventsystem
+            ${CMAKE_SOURCE_DIR}/iocore/dns
+            ${CMAKE_SOURCE_DIR}/iocore/io_uring
+            ${CMAKE_SOURCE_DIR}/iocore/aio
+            ${CMAKE_SOURCE_DIR}/iocore/net
+            ${CMAKE_SOURCE_DIR}/iocore/cache
+            ${CMAKE_SOURCE_DIR}/iocore/hostdb
+            ${CMAKE_SOURCE_DIR}/proxy
+            ${CMAKE_SOURCE_DIR}/proxy/http
+            ${CMAKE_SOURCE_DIR}/proxy/hdrs
+            ${CMAKE_SOURCE_DIR}/mgmt
+            ${CMAKE_SOURCE_DIR}/mgmt/utils
 )
-target_include_directories(inkdns PRIVATE
-        ${CMAKE_SOURCE_DIR}/iocore/eventsystem
-        ${CMAKE_SOURCE_DIR}/iocore/dns
-        ${CMAKE_SOURCE_DIR}/iocore/io_uring
-        ${CMAKE_SOURCE_DIR}/iocore/aio
-        ${CMAKE_SOURCE_DIR}/iocore/net
-        ${CMAKE_SOURCE_DIR}/iocore/cache
-        ${CMAKE_SOURCE_DIR}/iocore/hostdb
-        ${CMAKE_SOURCE_DIR}/proxy
-        ${CMAKE_SOURCE_DIR}/proxy/http
-        ${CMAKE_SOURCE_DIR}/proxy/hdrs
-        ${CMAKE_SOURCE_DIR}/mgmt
-        ${CMAKE_SOURCE_DIR}/mgmt/utils
-)

Review Comment:
   Not that I could see :/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org